Conversation
This was referenced Sep 30, 2026
zzylol
marked this pull request as ready for review
September 30, 2026 16:10
zzylol
force-pushed
the
fix/typed-maintenance-binary
branch
from
September 30, 2026 18:27
a049a3b to
acdea1d
Compare
zzylol
force-pushed
the
refactor/candidate-post-asap-dags
branch
from
September 30, 2026 18:27
ea12b31 to
763bef3
Compare
Rename the public candidate collection, signatures, re-exports, rustdoc, examples, and tests without changing candidate storage or selection behavior. Remove the old type name rather than keeping an alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
fix/typed-maintenance-binary
branch
from
September 30, 2026 20:25
acdea1d to
1e210a3
Compare
zzylol
force-pushed
the
refactor/candidate-post-asap-dags
branch
from
September 30, 2026 20:25
763bef3 to
11f4eeb
Compare
zzylol
added a commit
that referenced
this pull request
Sep 30, 2026
Describe the two plain candidate collections, the view-based compile, the caller-typed physical candidate errors, lifecycle_guarantee, and PhysicalExecution as an execution handle. Remove APIs the docs said were removed but never existed (compile_timed_candidates, PhysicalDAGCandidate), the agent instructions in the alignment proposal's baseline, and the ingestion-time Binary exception from design docs, where it is an implementation detail (the developer migration guide keeps it). Restore #485's statement that candidates do not choose placement and #508's CandidatePostASAPDAGs<Id> names in input-output-workflow.md, rejoin the split test table in physical-planning-and-deployment.md, and take planner-backend-layering.md verbatim from #509. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #507.
Implements the API naming requested alongside #480.
Why
The public candidate collection should be named for its contents: candidate PostASAPDAGs.
What
Rename
PlanSpace<Id>toCandidatePostASAPDAGs<Id>throughout the Rust API, public re-exports, return types, references, tests, examples, and documentation. Remove the old name without a compatibility alias. The compact representation, candidate enumeration, costing, selection, and DAG assembly behavior are unchanged.Before this PR
Callers referred to
asap_aware_mapping::PlanSpace<Id>and its associated methods.After this PR
Callers use
asap_aware_mapping::CandidatePostASAPDAGs<Id>. Search functions return that type; callers can enumerate candidates or explicitly invoke selection helpers as before.Validation
Formatting, whitespace checks, full workspace all-target Clippy with warnings denied, and full workspace tests passed. Reverse-renaming and formatting reproduce the original Rust files exactly, confirming that this is a naming-only change. Backend workspace all-target Clippy and all control-plane tests passed against this exact revision (ProjectASAP/ASAPQuery-backend#812).
The extra strict rustdoc check (
RUSTDOCFLAGS="-D warnings" cargo doc -p asap-aware-mapping --no-deps) fails with 93 pre-existing documentation diagnostics. Running the same check on the parent revision produces the identical diagnostic set after normalizing the renamed identifier; this change introduces no new rustdoc diagnostics.🤖 Generated with Claude Code