Conversation
This was referenced Sep 29, 2026
zzylol
force-pushed
the
split/462-d-runtime
branch
from
September 29, 2026 20:56
a4cd03b to
1d89c99
Compare
zzylol
force-pushed
the
split/462-f-physical-planner
branch
from
September 29, 2026 20:56
e2d23b3 to
31a3790
Compare
zzylol
force-pushed
the
split/462-d-runtime
branch
from
September 29, 2026 21:19
1d89c99 to
5c205e3
Compare
zzylol
force-pushed
the
split/462-f-physical-planner
branch
from
September 29, 2026 21:19
31a3790 to
4d0dbc0
Compare
Add `physical_planner`: reader-independent compilation of selected logical candidates into precompute/query physical DAGs with typed materialization frontiers, bounded frontier enumeration, workload cost selection, temporal KLL pane compilation and PromQL row/value lowering. `dag` remains a compatibility re-export. Tests cover physical DAGs, plan recovery, precompute candidates and populations, PromQL values and binaries, weighted TopK binding and current-series heaps, plus Planner-to-execution integration tests. The design doc describes the ownership boundary with deployments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
split/462-d-runtime
branch
from
September 29, 2026 22:56
5c205e3 to
f95ffd4
Compare
zzylol
force-pushed
the
split/462-f-physical-planner
branch
from
September 29, 2026 22:56
4d0dbc0 to
bb1abdd
Compare
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of the #462 split. Stacked on #474; it builds on #472, which is already merged into main.
Before this PR
The Planner selects logical Post-ASAP candidates (#472, merged) and has a shared runtime (#474), but nothing turns a selection into executable physical DAGs. Deployments do that lowering themselves.
After this PR
SketchQuerypasses through unchanged, so there is no Statistic/string-parameter round trip.CompiledPhysicalDagandPhysicalCandidatederive serde and are validated on deserialization. They have no Planner byte format or version.dagis kept as a compatibility re-export.Boundary change from #462
The Planner stays deployment-agnostic. These parts of #462 are left out and go to ASAPQuery-backend in a separate PR:
The design doc states this ownership.
Validation
cargo test --workspacepassed 1356 tests, covering physical DAGs, plan recovery, precompute candidates and populations, PromQL values and binaries, weighted TopK binding, current-series heaps, and the KLL pane, SQL→physical and lifecycle end-to-end tests. Stored pane states are passed in memory; byte encodings are tested in sketchlib and deployments.cargo clippy --workspace --all-targets -D warningsis clean. These are shared-library tests, not deployment end-to-end tests.Split stack: #472 · #473 · #474 · this PR.
🤖 Generated with Claude Code