Skip to content

Use git dependency for asap_sketchlib and fix build against Sketchlib main #607

Description

@milindsrivastava1997

asap-precompute-rs depends on Sketchlib via a relative path:

asap_sketchlib = { path = "../../asap_sketchlib" }

Downstream repos that consume Collector from git (e.g. ASAPQuery-backend) can't resolve this and need a [patch."https://github.com/ProjectASAP/ASAPCollector"] workaround.

Also, asap-precompute-rs doesn't build against current Sketchlib main (932ab4a):

error[E0063]: missing fields `negative_store_counts`, `negative_store_offset` and `zero_count` in initializer of `DdSketchState`

Fix

  • Switch to asap_sketchlib = { git = "https://github.com/ProjectASAP/asap_sketchlib" } (bare URL, no branch/rev, so it unifies with other consumers).
  • Update the DdSketchState initializer for the new fields.
  • For local Sketchlib development, use an untracked .cargo/config.toml [patch] pointing at the local checkout.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions