-
Notifications
You must be signed in to change notification settings - Fork 250
FOUR-33117: Remove data lake views #9047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+47
−26
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 0 additions & 26 deletions
26
database/migrations/2023_03_13_172619_create_data_lake_views.php
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <?php | ||
|
|
||
| use Illuminate\Support\Facades\Artisan; | ||
| use ProcessMaker\Upgrades\UpgradeMigration as Upgrade; | ||
|
|
||
| class DropDataLakeViews extends Upgrade | ||
| { | ||
| /** | ||
| * Run any validations/pre-run checks to ensure the environment, settings, | ||
| * packages installed, etc. are right correct to run this upgrade. | ||
| * | ||
| * Throw a \RuntimeException if the conditions are *NOT* correct for this | ||
| * upgrade migration to run. If this is not a required upgrade, then it | ||
| * will be skipped. Otherwise the exception thrown will be caught, noted, | ||
| * and will prevent the remaining migrations from continuing to run. | ||
| * | ||
| * Returning void or null denotes the checks were successful. | ||
| * | ||
| * @return void | ||
| * | ||
| * @throws RuntimeException | ||
| */ | ||
| public function preflightChecks() | ||
| { | ||
| // | ||
| } | ||
|
|
||
| /** | ||
| * Run the upgrade migration. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function up() | ||
| { | ||
| Artisan::call('processmaker:create-data-lake-views', ['--drop' => true]); | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the upgrade migration. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function down() | ||
| { | ||
| // | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped views get recreated
High Severity
The drop in
DropDataLakeViewsdoes not last becauseUpdateDataLakeViewsstill runsprocessmaker:create-data-lake-viewsonMigrationsEnded. After this upgrade, a latermigrateor a new install'smigrate:freshrecreates thedlv_*views, so they remain in the database.Reviewed by Cursor Bugbot for commit e071817. Configure here.