deps(deps): bump argon2 from 0.5.3 to 0.6.0 - #10318
dependabot[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c8dbff3 to
94988dc
Compare
|
This bump does not compile: Three call sites need migrating: the That is why I took this into merge train 207 on the strength of a clean cherry-pick and no file overlap, and the train's release build caught it. It has been dropped from that train; the train landed the rest. This PR needs the call-site migration before it can go in. |
4ee4688 to
184dec2
Compare
|
Follow-up with the concrete 0.6 API, since the migration is not a pure rename. In
So the two call sites in let salt = SaltString::generate(&mut OsRng);
argon2.hash_password(password.as_bytes(), &salt)and there is a real choice to make rather than one obvious rewrite:
I am deliberately not picking one as a merge-train repair: it changes where salt entropy comes from in a password-hashing path, and which feature gets enabled is a decision for whoever owns this module. Whichever is chosen, the verification that matters is a round-trip — hash, then |
Bumps [argon2](https://github.com/RustCrypto/password-hashes) from 0.5.3 to 0.6.0. - [Commits](RustCrypto/password-hashes@argon2-v0.5.3...argon2-v0.6.0) --- updated-dependencies: - dependency-name: argon2 dependency-version: 0.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
184dec2 to
0eb1046
Compare
|
Closing this for now — not worth the migration cost at present. This is a routine version bump, not a security update: no advisory affects The bump does not compile, and the work needed is a real API migration rather than a version edit. That is a decision for whoever owns password hashing, not something to settle inside a dependency bump. Reopening this later is cheap; landing the wrong salt source is not. Dependabot will re-raise the bump on its next run if the dependency is still behind. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps argon2 from 0.5.3 to 0.6.0.
Commits
b1e0ad6argon2 v0.6.0 (#931)c0d2acaargon2: bumpblake2to v0.11 (#929)d9c628bCargo.lock: bump dependencies (#930)0b31c1cCargo.toml: usepassword-hashcrate release (#920)420cbc9build(deps): bump rust-lang/crates-io-auth-action from 1.0.4 to 1.0.5 (#912)3a88540build(deps): bump actions/checkout from 6 to 7 (#913)90b974fbuild(deps): bump the all-deps group with 5 updates (#914)82c688fbuild(deps): bump the all-deps group across 1 directory with 18 updates (#911)b2cef17build(deps): bump the all-deps group with 6 updates (#902)2c16e5abuild(deps): bump the all-deps group with 7 updates (#901)