Repository navigation
Fix the about page after merging the German version - #25
Merged
Merged
Conversation
Merging the about page with the language support left /about rendering without the language data the template now needs, so it answered 500, and the nav link to it was lost in the merge. /about and /de/about now go through the same language handling as posts: about.de.md is picked up when it exists, otherwise /de/about shows the English page with a note and a canonical link to /about. The nav link is back and points to the page in the current language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by PatrickLaabs · project thread
Before: on
main,/aboutanswers 500 (index of untyped nilin the template), because the merge of #23 and #24 left the about handler without the language data the template now needs. The~/aboutlink in the nav was also lost in the merge.After:
/aboutworks again, and/de/aboutexists. Ifblog/about.de.mdis present it is shown there; until then/de/aboutshows the English page with the note "Diese Seite gibt es nur auf Englisch." and a canonical link to/about. The nav link is back and points to the about page in the current language.How: the about page is loaded like posts, one version per language (
about.md,about.<lang>.md), and its route is registered per language through the samepageDataas the other pages.Generated by Claude Code