Skip to content

Show sources of disabled damage types on Calcs page - #10314

Open
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/show-damage-disable-sources
Open

Show sources of disabled damage types on Calcs page#10314
AdamZ-8113 wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
AdamZ-8113:feature/show-damage-disable-sources

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

It's really confusing to see that a build does no damage of various types on the Calcs tab, unless you're already familiar with many of the sources of restriction like Replica Alberon's, Avatar of Fire, Brutality, Void Manipulation, etc. This small change leverages boolean values that PoB already calculates, and simply shows them on hover in the calcs page for the given damage types.

Steps taken to verify a working solution:

  • Load several builds with several different sources of damage restriction
  • Compare to baseline dev branch
  • Confirm numbers and modList data looks accurate
  • Full test suite passed

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant