Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadContext.downloadfetches the vanilla jar withURL.openStream(), which has no connect or read timeout. If the CDN accepts the connection and then stalls, Paperclip waits forever: there is no exception to catch and nothing is logged afterDownloading …. We hit this in CI, where a first start with an emptybundlerRepoDirhung until the job's own timeout killed it, and the only fix was to wrap Paperclip in a timeout from outside.This opens the URL through
URLConnectionwith a 30s connect and read timeout, and retries the download up to three times before giving up the way it does today (print the exception, exit 1).A dropped connection mid-body is a related case:
HttpURLConnectionreturns end-of-stream rather than throwing, so the short file only shows up at the hash check, which threw with no retry. The hash check now sits inside the same loop, so a truncated download is retried too and only the third failure throws.Tested by hand with a small
DownloadContextdriver against a local HTTP server:Read timed outafter 30s each, then exit 1Hash check failed … (attempt n of 3)lines, then success./gradlew buildpasses.