fix(http): allow server_list to satisfy missing server validation - #660
Draft
corporate-gadfly wants to merge 1 commit into
Draft
corporate-gadfly wants to merge 1 commit into
corporate-gadfly wants to merge 1 commit into
Conversation
OpenVox recently tightened HTTP service creation checks so that a missing `server` setting now raises an error. That unintentionally broke valid configurations that rely on `server_list` instead of a single `server`. Update `Puppet::HTTP::Service.create_service` to treat `server_list` as a valid source of server configuration when no explicit server argument is provided. This keeps the security-related no-default-server behavior intact while restoring compatibility for agents configured via `server_list`. Signed-off-by: Corporate Gadfly <haroon.rafique@gmail.com> Co-Authored-By: GPT-5.4 Mini <noreply@openai.com>
Contributor
Author
|
I don't know Ruby that well, so I would prefer to use #659, if possible. |
Contributor
|
Unfortunately I think this will still fail on systems with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenVox recently tightened HTTP service creation checks so that a missing
serversetting now raises an error. That unintentionally broke valid configurations that rely onserver_listinstead of a singleserver.Update
Puppet::HTTP::Service.create_serviceto treatserver_listas a valid source of server configuration when no explicit server argument is provided. This keeps the security-related no-default-server behavior intact while restoring compatibility for agents configured viaserver_list.Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent