Repository navigation
fix(imports): use s3 storage for temporary csv imports - #630
Merged
Merged
Conversation
… s3) Ticket, event, registration company and selection plan member imports were hard bound to the swift storage strategies. Add FILESYSTEMS_IMPORTS_STORAGE (default swift) so an environment without a working swift backend can use the s3 disk instead.
Drop the FILESYSTEMS_IMPORTS_STORAGE switch: ticket, event, registration company and selection plan member imports are bound to the s3 strategies unconditionally.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/summit-api/openapi/pr-630/ This page is automatically updated on each push to this PR. |
smarcet
added a commit
that referenced
this pull request
Oct 12, 2026
#630 bound the ticket, event, registration company and selection plan member imports to the s3 storage strategies, but the tests still faked and wrote to the swift disk. In CI the real s3 disk has no region, so the imports threw "Missing required client configuration options" and SummitServiceTest, SummitSelectionPlanServiceTest and the oauth2 ingest tests failed. Fake and write to the s3 disk instead, and fake it in the two ticket ingest tests that previously relied on the real disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CSV imports (tickets, events, registration companies, selection plan allowed members) save the uploaded file to storage, then a queued job reads it back, processes it and deletes it.
SummitService,SummitOrderServiceandSummitSelectionPlanServicewere hard bound to the Swift storage strategies for that temporary file.On dev the Swift backend is failing: every ticket import job (
ProcessTicketDataImport) dies about 3 seconds after starting withOpenStack\Common\Error\BadResponseError: HTTP Error, before processing any row. The upload request still returns OK, so the admin sees no error and nothing gets imported.This PR binds the three services to
S3StorageFileUploadStrategy/S3StorageFileDownloadStrategy(thes3disk,AWS_*vars). The storage only holds temporary import files undertmp/…that are deleted when the job finishes, so no persisted data is left in Swift.Deployment steps
s3disk must be configured (AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY,AWS_DEFAULT_REGION,AWS_BUCKET,AWS_ENDPOINT) with write access to the bucket.php artisan queue:restartafter deploy so workers pick up the new binding.Tests
Resolved the three services from the container and checked both strategies report the
s3driver:Summary by CodeRabbit