Repository navigation
Conversation
setAuthHandlers registers optional replacements: initLogOut for the IDP
end-session redirect, authErrorHandler for the 401 login / 403 logout
paths. The two keys are independent, and without handlers uicore keeps
its built-in behavior.
The handlers live on globalThis under
Symbol.for('openstack-uicore-foundation.authHandlers'), so every copy of
the module shares them.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
setAuthHandlers and readAuthHandlers used bare globalThis. They now use
the _global fallback (globalThis → window → {}) that the resolver already
uses, so initLogOut keeps its built-in redirect on a runtime without
globalThis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86bbnquuq
5.x sibling of #350 (v4.x). Based on #329 (resolver 5.x).
setAuthHandlerslets a consumer injectinitLogOutand the 401/403 handler in one setter:setAuthHandlers({ initLogOut, authErrorHandler }), withgetAuthHandlersto read them back. When registered uicore delegates; otherwise the built-in flow is unchanged. Same opt-in shape assetAccessTokenResolver(#329).