Release v5.0.0 - #281
Merged
Merged
Conversation
Set the package version to 4.4.0 and name the changelog section that ships. #262 merged after v4.3.1 but re-added its entry to the already-released v4.1.0 section, where an earlier attempt at the same rewrite had lived before being pulled back out. The notes `bin/release` extracts would therefore have described #271 alone. The entry moves verbatim into the v4.4.0 section. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KZNS4xoFuTFKeQDz5yuz3W
Member
|
The shrinkwrap being continuous makes this a breaking release. It's results are different than the gridded approach from before |
Contributor
Author
|
Local full suite: PASS (7 min, Julia 1.12.7, one cell of the matrix) |
1-Bort-1
commented
Sep 7, 2026
1-Bort-1
left a comment
Contributor
Author
There was a problem hiding this comment.
Independent review (advisory)
Verdict: APPROVE · 0 inline, 0 off the diff
Good
- Diff is one idea and minimal: git confirms only CHANGELOG.md and Project.toml changed (+18/-15, 13 of the deletions the moved block), matching the card's Scope.
- The #262 entry move is byte-identical: extracted the 13-line block from main (lines 330-342) and HEAD (lines 29-41) and diffed them — identical, so the 'pure move' claim holds.
- The move is substantively correct:
pivot_contour/min_clearancegrep absent at the v4.3.1 tag and present at HEAD, so #262 shipped in no release and its notes were misattributed under the already-released v4.1.0 heading. - Release tooling now passes: bin/release's guard compares Project.toml (4.4.0) against the first versioned
##header (v4.4.0 2026-09-07), and its awk extraction yields exactly the new section. - Removal leaves the v4.1.0
### Changedsubsection intact (SolverSettings/AIC/is_show bullets remain at lines 319-355) — no dangling empty heading. - Card is honest per rule 6: 'No tests run' justified by grep, deno fmt absence disclosed, CI mirror started-not-waited disclosed, and the stale-date risk self-flagged.
- Surprises routed per rubric §5: the bin/release version-guard bug was filed as #280 with an explicit 'do not run agent release' warning instead of being silently worked around.
- Scope call (rescuing #262's entry inside the release PR rather than a second PR) is argued in Decisions against §4 Releasing step 1, not hidden.
Not good
- Header date 2026-09-07 is only right if merged today; the author flags this himself as the one risk.
- Rubric §9 calls Project.toml bumps Bart's job; defensible here because the release was requested and merging makes the bump his, but it is the one rubric line this PR touches.
- The 4.4.0-vs-breaking call on the
cell_size→min_clearancefield rename is the author's judgment, transparently deferred to Bart — registration is irreversible.
opencode, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016TgCWZVmVByLWrA5sStHry
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Sets
Project.tomlto 5.0.0 and names the shipping changelog section## VortexStepMethod v5.0.0 2026-09-07. That section also gains #262's entry,which sat under the already-released v4.1.0 heading and would otherwise have
been dropped from the release notes; it is prefixed
BREAKING:.Verification
bin/release's own version guard and notes-extraction stanzas, runagainst the working tree: version guard yields
v5.0.0, matchingProject.toml; notes come out as### Added(5 bullets) plus### Changed(1 bullet,BREAKING:). Onmainat0a8f046the guardyields
v4.3.1— see the surprise below.git diff --word-diffoverCHANGELOG.mdfor the latest commit showsexactly three tokens:
-v4.4.0,+v5.0.0,+BREAKING:. The 13-linebullet is rewrapped to 80 columns, and the word diff proves no wording
moved with it.
main's (diff,exit 0) apart from that rewrap.
maingreen: run 34126474537 on0a8f046, all 7 jobs includingDocumentation. Rebased on
main, which has not moved.git diff origin/main -- src test docs README.mdis empty, so the tree under test ismain's. Nothing insrc/,test/ordocs/readsProject.toml's version orCHANGELOG.md(grepped).
deno fmtnot run — deno is not on the box and no workflowformats markdown; the changed lines are ≤ 80 columns. REUSE lint n/a.
Reviewer's guide
Project.tomlis the whole of one of them.CHANGELOG.md, read the header and the first three words of the### Changedbullet.git show --color-moved=zebra 74c72cfgreys the movedblock;
git show --word-diff 5612d24is the reclassification on its own.2026-09-07; merging on a later day wants that changed.Decisions
continuous makes this a breaking release. It's results are different than the
gridded approach from before." This repo bumps the major for that — its only
other
BREAKINGentries sit underv4.0.0— so a breaking release offv4.3.1isv5.0.0. Say the word before merging if you meant to keep thenumber and only flag the notes.
BREAKING:prefix goes on Continuous wrapping method #262's entry, which is where the break is: thewrap is a different shape (a V3 canopy's aft strip comes out
2 * clearancethick where the grid gave
3.5 * cell_size), andShrinkWrap'scell_sizefield is renamed
min_clearance— construction still takescell_size=(
shrink_wrap.jl:42-44), butsw.cell_sizenow errors. AGENTS.md §4 spellsthe prefix
BREAKING:; the v4.0.0 entries useBREAKING -. Followed therules file.
me to check. Continuous wrapping method #262 is in
v4.3.1..maintoo, andpivot_contour/min_clearanceexist onmainbut not atv4.3.1, so it has shipped in norelease.
536a67freturned its entry to the v4.1.0 section because an earlierattempt at that rewrite lived there before
2030908pulled it out pre-v4.1.0.Moving it is the same idea as the rest of this PR, and §4 Releasing step 1
wants it before
bin/releaseruns — so it is here, not in a second PR therelease would also wait for.
its
### Fixedentry stays on its own branch.##header, so an## Unreleasedsection makes it re-register the last release #280:bin/release's version guard scans every##header rather than the top one, so with
## Unreleasedon top it matchedv4.3.1and would have re-registered an existing tag under the unreleasednotes.
agent releasemust not run until this PR merges.mesh:andairfoil:are reachable only through docstrings #278 (no settings-file reference page, and the README nevermentions settings files — predates this release, so it did not hold it up)
and cleanup: CI.yml carries
fail-fast: false, so a broken matrix runs every job to the end #279 (fail-fast: falseinCI.yml).Scope
+18 / -15 across 2 files; the bulk is #262's entry moved into the shipping
section. Branch is still named
agent/276-release-v4-4-0; renaming it wouldrewrite a pushed branch, so it stays.
🤖 Generated with Claude Code
https://claude.ai/code/session_016TgCWZVmVByLWrA5sStHry
Closes #276 · task
VortexStepMethod.jl-276