Skip to content

Release v5.0.0 - #281

Merged
1-Bart-1 merged 2 commits into
mainfrom
agent/276-release-v4-4-0
Sep 7, 2026
Merged

Release v5.0.0#281
1-Bart-1 merged 2 commits into
mainfrom
agent/276-release-v4-4-0

Conversation

@1-Bort-1

@1-Bort-1 1-Bort-1 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Sets Project.toml to 5.0.0 and names the shipping changelog section
## VortexStepMethod v5.0.0 2026-09-07. That section also gains #262's entry,
which sat under the already-released v4.1.0 heading and would otherwise have
been dropped from the release notes; it is prefixed BREAKING:.

Verification

  • bin/release's own version guard and notes-extraction stanzas, run
    against the working tree: version guard yields v5.0.0, matching
    Project.toml; notes come out as ### Added (5 bullets) plus
    ### Changed (1 bullet, BREAKING:). On main at 0a8f046 the guard
    yields v4.3.1 — see the surprise below.
  • git diff --word-diff over CHANGELOG.md for the latest commit shows
    exactly three tokens: -v4.4.0, +v5.0.0, +BREAKING:. The 13-line
    bullet is rewrapped to 80 columns, and the word diff proves no wording
    moved with it.
  • The Continuous wrapping method #262 block this PR moved up is byte-identical to main's (diff,
    exit 0) apart from that rewrap.
  • main green: run 34126474537 on 0a8f046, all 7 jobs including
    Documentation. Rebased on main, which has not moved.
  • No tests run and no local CI mirror: git diff origin/main -- src test docs README.md is empty, so the tree under test is main's. Nothing in src/,
    test/ or docs/ reads Project.toml's version or CHANGELOG.md
    (grepped). deno fmt not run — deno is not on the box and no workflow
    formats markdown; the changed lines are ≤ 80 columns. REUSE lint n/a.

Reviewer's guide

  • Two files, and Project.toml is the whole of one of them.
  • In CHANGELOG.md, read the header and the first three words of the
    ### Changed bullet. git show --color-moved=zebra 74c72cf greys the moved
    block; git show --word-diff 5612d24 is the reclassification on its own.
  • Risk: the header says 2026-09-07; merging on a later day wants that changed.

Decisions

Scope

+18 / -15 across 2 files; the bulk is #262's entry moved into the shipping
section. Branch is still named agent/276-release-v4-4-0; renaming it would
rewrite a pushed branch, so it stays.

🤖 Generated with Claude Code

https://claude.ai/code/session_016TgCWZVmVByLWrA5sStHry

Closes #276 · task VortexStepMethod.jl-276

Set the package version to 4.4.0 and name the changelog section that ships.

#262 merged after v4.3.1 but re-added its entry to the already-released v4.1.0
section, where an earlier attempt at the same rewrite had lived before being
pulled back out. The notes `bin/release` extracts would therefore have
described #271 alone. The entry moves verbatim into the v4.4.0 section.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KZNS4xoFuTFKeQDz5yuz3W
@1-Bart-1

1-Bart-1 commented Sep 7, 2026

Copy link
Copy Markdown
Member

The shrinkwrap being continuous makes this a breaking release. It's results are different than the gridded approach from before

@1-Bort-1

1-Bort-1 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Local full suite: PASS (7 min, Julia 1.12.7, one cell of the matrix)

@1-Bort-1 1-Bort-1 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review (advisory)

Verdict: APPROVE · 0 inline, 0 off the diff

Good

  • Diff is one idea and minimal: git confirms only CHANGELOG.md and Project.toml changed (+18/-15, 13 of the deletions the moved block), matching the card's Scope.
  • The #262 entry move is byte-identical: extracted the 13-line block from main (lines 330-342) and HEAD (lines 29-41) and diffed them — identical, so the 'pure move' claim holds.
  • The move is substantively correct: pivot_contour/min_clearance grep absent at the v4.3.1 tag and present at HEAD, so #262 shipped in no release and its notes were misattributed under the already-released v4.1.0 heading.
  • Release tooling now passes: bin/release's guard compares Project.toml (4.4.0) against the first versioned ## header (v4.4.0 2026-09-07), and its awk extraction yields exactly the new section.
  • Removal leaves the v4.1.0 ### Changed subsection intact (SolverSettings/AIC/is_show bullets remain at lines 319-355) — no dangling empty heading.
  • Card is honest per rule 6: 'No tests run' justified by grep, deno fmt absence disclosed, CI mirror started-not-waited disclosed, and the stale-date risk self-flagged.
  • Surprises routed per rubric §5: the bin/release version-guard bug was filed as #280 with an explicit 'do not run agent release' warning instead of being silently worked around.
  • Scope call (rescuing #262's entry inside the release PR rather than a second PR) is argued in Decisions against §4 Releasing step 1, not hidden.

Not good

  • Header date 2026-09-07 is only right if merged today; the author flags this himself as the one risk.
  • Rubric §9 calls Project.toml bumps Bart's job; defensible here because the release was requested and merging makes the bump his, but it is the one rubric line this PR touches.
  • The 4.4.0-vs-breaking call on the cell_sizemin_clearance field rename is the author's judgment, transparently deferred to Bart — registration is irreversible.

opencode, rubric CLEAN_CODE.md. A different lab from the implementer
on purpose: a reviewer sharing its blind spots would not flag its mistakes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016TgCWZVmVByLWrA5sStHry
@1-Bort-1 1-Bort-1 changed the title Release v4.4.0 Release v5.0.0 Sep 7, 2026
@1-Bort-1 1-Bort-1 mentioned this pull request Sep 7, 2026
@1-Bart-1
1-Bart-1 merged commit c90ece8 into main Sep 7, 2026
8 checks passed
@1-Bart-1
1-Bart-1 deleted the agent/276-release-v4-4-0 branch September 7, 2026 14:04
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release v4.4.0

2 participants