keychron: let the M6 set its DPI stage count - #106
Merged
snekxs merged 1 commit intoSep 16, 2026
Merged
Conversation
The settings packet already carried the count at byte 14 and parseStatus already read it back, so the wire format was known; only the setter was missing, which left countEditable false and the stage picker hidden. The active stage rides on the same packet, so shrinking past it would write a stage the mouse cannot hold. Clamp it first. The count write itself has not been exercised on hardware: until now the field was only ever written back with the value just read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The M6 now reports `countEditable: true` and implements `setDpiStageCount`, so the shared stage editor shows the stage count picker (1 to 5) instead of hiding it.
Why
The settings packet already carries the stage count at byte 14 and `parseStatus` already reads it back, so the wire format was known. Only the setter was missing, which kept the picker hidden.
Details
Testing
Not yet exercised on hardware: until now the count field was only ever written back with the value just read. The app needs no change, `applyDpiStageCount` already gates on `countEditable` and `setDpiStageCount`.