Conversation
The DPI panel rendered for every device and its Apply called setDpi even when the connected driver has no setter, so the Attack Shark X11's native channel failed with 'No driver answered setDpi: AttackSharkHidClient: setDpi not supported'. Render the panel only when the device reports a DPI value; a driver that cannot read one simply does not show a control that cannot work.
The X11's sensor reaches 22,000 DPI in 50 DPI steps; the shared Logitech bounds (50-32000) would have allowed values the encoder cannot represent. Use the mouse's own range and presets when the connected brand is Attack Shark.
hyusband
changed the title
The X11 (wired 0xfa55 and 2.4 GHz receiver 0xfa60) rendered the generic placeholder. Add a top-down render, cropped from the vendor's official product image and keyed onto transparency, and map both transports to it. The R1 (0xfa61) is a different mouse and stays on the placeholder.
hyusband
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Overview rendered the generic placeholder for the Attack Shark X11, the Performance tab rendered a DPI panel whose Apply called
setDpiunconditionally (failing withAttackSharkHidClient: setDpi not supported), and DPI bounds borrowed Logitech's 50-32000 range for every non-Razer brand.Change
public/devices/attackshark-x11.png- a top-down render cropped from the vendor's official product image and keyed onto transparency - and map1d57:fa55(wired) and1d57:fa60(2.4 GHz receiver) to it, plus a name fallback. The R1 (0xfa61) is a different mouse and stays on the placeholder.status.dpi > 0), so a driver that cannot read a DPI does not show a control whose Apply cannot work.Battery and polling rate now arrive from the driver change in OpenMouse-Project/mouse-protocol#103; no Desktop-side change is needed to display them.
Polling and the other capability-gated rows are unaffected.