Repository navigation
fix: Make measured_palettes option consistent with default: False - #150
Open
lucasfijen wants to merge 1 commit into
Open
lucasfijen wants to merge 1 commit into
lucasfijen wants to merge 1 commit into
Conversation
At a certain place the default value for measured_palettes was set to True, which is inconsistant with all the other default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the last update the default behavior of measured_palettes seems to have changed to True.
I found this default value to be inconsistent with all the other places where we declare measured_palettes as default False.
This fixes the default behaviour for the option to be default false again.
In my case this option on leads to some unwanted colour behaviour in combination with EE02 + 13.3 spectra screen.
A default behaviour to False prevents others from experiencing this too