Fix scrolling in node-type dropdowns - #668
Open
yiheng-kkk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #621.
Keep scroll and mousedown events inside the teleported menu from closing it, and leave the scrollbar's default action enabled. Scrolling the containing form or clicking outside still closes the menu.
Add a dependency-free browser regression page at
/tests/dropdown-scroll.html(cd frontend && npm ci && npm run dev). Its 10 cases cover internal scrolling, the last three node types, outside dismissal, and separate menu instances.Validation: production
npm run build; regression page in Chromium, Firefox, and WebKit; real wheel selection in all three and native scrollbar dragging in Chromium/WebKit;npx eslint tests/dropdown-scroll.js;git diff --check.Unchanged baseline limitations: full source ESLint reports the same 75 diagnostics;
uvx ruff check .reports 2,406.uv run --frozen pytest -vstalls in the existing WebSocket mock serialization; the other 66 tests pass. The YAML CI script exits successfully but does not invokeload_config; direct loading passes 5 files and needs environment placeholders for 40. No backend or dependency files changed.