Report AWS ECS target detail now the SDK deserialises the endpoint - #717
Merged
Conversation
go-octopusdeploy v2.116.0 added AwsEcsClusterEndpoint, so ECS targets no longer arrive with a nil endpoint. The target commands now name the type, show the cluster and region, and resolve the default worker pool. The tests that asserted the old unknown-type fallbacks cover a target with no endpoint at all instead, keeping the #604 regression guarded. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
enf0rc3
marked this pull request as ready for review
September 1, 2026 02:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests have been failing on
mainsince the go-octopusdeploy bump to v2.116.0 in #708. That release addedAwsEcsClusterEndpoint, so AWS ECS deployment targets no longer arrive with a nil endpoint, and five tests asserting the old unknown-type fallbacks started failing.The target commands now name the type as "AWS ECS Cluster", show the cluster and region as endpoint details, and resolve the default worker pool. Tests that covered the nil-endpoint path now use a target with no endpoint at all, so the #604 regression stays guarded.
Verified with
go test ./...from./pkg: the three target packages that fail onmainpass on this branch, and no other package changed state.🤖 Generated with Claude Code