Repository navigation
Conversation
Sections 3001-3003 overlap on 18 existing areaperils of the grid, in every combination of one, two and three sections, each with no hazard uncertainty, the same number of realisations everywhere, or different numbers between sections and return periods. Events 1-8 drive them. The cells are clear of section 2143's polygon and of tests/test_1's locations, so test_1 is unchanged. The lookup gets a join_sections step (type join_rows) after the section rtree, giving a location in several sections one keys value (3001;3002). make_confluence_data.py adds the example to the model data (and only it); show_confluence.py prints the footprint built at those areaperils. Requires OasisLMF with the join_rows step and the section merge (OasisLMF#2219); merge that first. Refs OasisLMF/OasisLMF#2218 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to OasisLMF/OasisLMF#2219 (issue OasisLMF/OasisLMF#2218). Merge OasisLMF#2219 first: this model's lookup now uses the
join_rowsstep, which only exists there, so this PR's automatic CI run (oasislmf frommain) fails until it lands. To test both together beforehand, run the model-tests workflow by hand withoasislmf_branch = feature/confluence-section-merge.What changes in
DynamicFootprintA confluence example: areaperils lying in several sections, which one event can drive at once.
tests/test_1's locations.test_1's portfolio only uses section 2143, so it never loads the new sections.probabilitycolumn, like the rest of the model: realisations are written as repeated rows (equal weights), e.g. .25/.5/.25 as one value once, one twice, one once.join_sectionsstep (typejoin_rows) after the section rtree gives a location in several sections one keys value (3001;3002).tests/test_2: the 18 locations, one loss line each, default section merge (max).make_confluence_data.pyadds the example to the model data, and only it;show_confluence.pyprints the footprint OasisLMF builds at those areaperils, without a model run.Verification (with OasisLMF#2219 installed)
test_1: output byte-identical to its existing expected results.test_2: every location gets exactly its sections in the keys; the footprint matches hand-computed values (e.g. event 1: S1+S3 gives 13 at rp 50, every region containing S2 gives 15 at rp 200); 126 event x location losses, all positive.--check-results.🤖 Generated with Claude Code