Skip to content

refactor(studio): make screenshot-set review the training-truth workflow - #32

Merged
Teakowa merged 1 commit into
mainfrom
refactor/issue-26-screenshot-set-review
Sep 30, 2026
Merged

Teakowa merged 1 commit into
mainfrom
refactor/issue-26-screenshot-set-review

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the platform reviewed-annotation snapshot importer with a finalized screenshot-set importer (platform contract: owbastion.com#255): fetch immutable set membership by integer version, download members from prefix-scoped R2, verify size_bytes + SHA-256 + decoded layout against platform-signed metadata, resume against verified workspace files, then create a Studio batch whose human review produces labels.
  • The set's accuracy mark propagates as accuracy_feedback through cases.json and review rows for prioritization only — it never becomes a transcription or training label. Studio review UI gains an "inaccurate first" ordering toggle and a 反馈有误 badge.
  • Removed: snapshot import routes/helpers, import_platform_snapshot.py (replaced by import_screenshot_set.py), split.py, materialized datasets/labeled/rec/platform support, and snapshot.json/provenance.json staging in remote runners (provenance now read from the exported batch.json; only set identity travels into run metadata).
  • The metadata contract forbids extra fields so QQ identity, player-account internals, grant/risk state, and evidence URLs cannot leak into a batch. Duplicate finalized-set imports are rejected with 409.

Fixes #26

Test plan

  • uv run pytest -q — 301 passed (new importer contract/integrity/resume tests + Studio route tests)
  • pnpm --dir training/studio/frontend build — clean
  • scripts/batch_eval.py --only-run-code (CI gate) — passed
  • Falsification: removing extra="forbid" fails the privacy tests; removing the SHA-256 check fails the integrity test
  • Live import against a real finalized set (requires platform env + R2 prefix config)

Generated with Devin

Replace the platform reviewed-annotation snapshot importer with a finalized screenshot-set importer that feeds the existing Studio review path: fetch immutable set membership by integer version, download member objects from prefix-scoped R2, verify size + SHA-256 + decoded layout against the platform-signed metadata, resume against verified workspace files, then create a Studio batch whose human review produces labels. The set's accuracy mark is carried as accuracy_feedback for review prioritization only and never becomes a transcription or training label. Snapshot routes, materialized platform datasets, and the split helper are removed; remote GPU run provenance reads the exported batch manifest.

Fixes #26
@Teakowa
Teakowa merged commit ad22f3d into main Sep 30, 2026
1 check passed
@Teakowa
Teakowa deleted the refactor/issue-26-screenshot-set-review branch September 30, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(studio): make Studio ROI review the primary training-truth workflow

2 participants