refactor(studio): make screenshot-set review the training-truth workflow - #32
Merged
Merged
Conversation
Replace the platform reviewed-annotation snapshot importer with a finalized screenshot-set importer that feeds the existing Studio review path: fetch immutable set membership by integer version, download member objects from prefix-scoped R2, verify size + SHA-256 + decoded layout against the platform-signed metadata, resume against verified workspace files, then create a Studio batch whose human review produces labels. The set's accuracy mark is carried as accuracy_feedback for review prioritization only and never becomes a transcription or training label. Snapshot routes, materialized platform datasets, and the split helper are removed; remote GPU run provenance reads the exported batch manifest. Fixes #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
size_bytes+ SHA-256 + decoded layout against platform-signed metadata, resume against verified workspace files, then create a Studio batch whose human review produces labels.accuracymark propagates asaccuracy_feedbackthroughcases.jsonand review rows for prioritization only — it never becomes a transcription or training label. Studio review UI gains an "inaccurate first" ordering toggle and a 反馈有误 badge.import_platform_snapshot.py(replaced byimport_screenshot_set.py),split.py, materializeddatasets/labeled/rec/platformsupport, andsnapshot.json/provenance.jsonstaging in remote runners (provenance now read from the exportedbatch.json; only set identity travels into run metadata).Fixes #26
Test plan
uv run pytest -q— 301 passed (new importer contract/integrity/resume tests + Studio route tests)pnpm --dir training/studio/frontend build— cleanscripts/batch_eval.py --only-run-code(CI gate) — passedextra="forbid"fails the privacy tests; removing the SHA-256 check fails the integrity testGenerated with Devin