Fix plots found while reviewing the generated docs images - #111
Draft
frankNiessen wants to merge 6 commits into
Draft
frankNiessen wants to merge 6 commits into
frankNiessen wants to merge 6 commits into
Conversation
- plotMap_KSvariantPairs: with parentGrainId, restrict the grey EBSD map to the chosen parent grain - plotMap_blockWidths: pass 'noMarker' to quiver (MTEX 7 marks grain centres by default) and draw the mean of the projected points as an axis - plotPDF_variants/packets/bain: stepped colorbar with one colour per Id, as in the maps
MTEX 7 draws quiver(grains,...) in 3D, so arrows lying in the map plane are hidden by the map and only their heads show. liftAboveMap lifts them slightly towards the viewer. Used for the block width traces and the habit plane traces, which also no longer mark every grain centre. plotMap_KSvariantPairs with parentGrainId no longer draws the boundaries of all grains, which made the whole map appear.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #110; retargets to
mainonce #110 is merged and its branch deleted.What does this change?
liftAboveMap(new,src/util): MTEX 7 drawsquiver(grains,...)arrows in 3D, so arrows lying in the map plane are hidden by the map itself and only their heads show. This lifts them slightly towards the viewer. Documented in the function index.plotMap_blockWidths: trace, normal and "mean of projected points" are visible again (lifted, the mean drawn as a line through the centre, no MTEX 7 centre markers).computeHabitPlane: the fitted traces are drawn as lines again instead of dots (same cause).plotMap_KSvariantPairs: withparentGrainId, only the chosen parent grain is shown (grey background and boundaries), not the whole map.plotPDF_variants,plotPDF_packets,plotPDF_bain: stepped colorbar with one colour per Id, matching the maps.Why?
Found while reviewing the images generated in #110 against the previously published ones.
How was it tested?
mh_lint/ pre-commit clean;mkdocs build --strictpasses.docs-review/compare/index.htmlin thedoc-imagesartifact of the latest run) was checked for block widths, habit plane, KS variant pairs, the pole figure colorbars and the stack.Checklist
pre-commit run --all-filespassesdocs/function_index.mdCHANGELOG.mdupdated