Repository navigation
Fix activity paging when limit exceeds HDX maximum and simplify recent additions - #121
Merged
Merged
Conversation
…t additions - Cap activity list limit at 100 when getting all pages, as HDX silently caps it and paging stopped after the first page - Share get_activities body via HDXObject._get_activities - Share download code between Resource.download and download_datastore - Use cls in User.get_current_token_info - Simplify data dictionary merge loop
|
coverage: 97.319% (-0.001%) from 97.32% — fix/activity-paging-and-simplify into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Activity.get_activities(..., all_pages=True, limit=N)with N > 100 returned only the first 100 activities. HDX silently capslimitatckan.activity_list_limit_max(100, per CKAN'sckanext/activity/logic/schema.py), so the first page came back shorter than the requested limit and paging stopped._get_listnow caps the limit at 100 when paging. The test mock now applies the same cap, and a new test coverslimit=500.Simplifications
get_activitiesbody in Dataset, Organization, Location and User intoHDXObject._get_activitiesResource.downloadandResource.download_datastoreintoResource._download_file.file_formatis now lowercased once indownload_datastore.User.get_current_token_infousesclsinstead ofUserupdate_hdx_data_dictionarymerge loop