Repository navigation
Reject page_size < 1 and csv/tsv records_format in get_datastore_records - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_datastore_recordsnow raisesHDXErrorfor two inputs it cannot handle:page_sizebelow 1. Withpage_size=0, CKAN returns no records and the loop check0 < 0is false, so it requests offset 0 forever. On stage, it was stopped after 10 identical calls.records_formatcsv or tsv. CKAN returnsrecordsas a single string for these formats, soyield from recordsyields single characters andlen(records)counts characters, not rows. On stage, a 27-row resource withpage_size=10yielded 7,795 characters.search_datastorehandles these formats correctly and remains the way to get them.Both errors are raised on the first iteration, since the method is a generator. Neither case worked before, so no working caller is affected. The docstring and
documentation/index.mdnote the csv/tsv restriction.