Repository navigation
Page datastore records past HDX's row cap, warn on truncated SQL results, and document TDE - #117
Merged
Merged
Conversation
…lts, and document TDE
mcarans
approved these changes
Oct 14, 2026
mcarans
left a comment
Contributor
There was a problem hiding this comment.
Tested on stage and fixes the page size > 32,000 bug. Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mcarans can you review this?
Makes the 6.7.1 datastore helpers hold up against HDX's 32,000-row cap, and ties the Datastore docs to HDX's Tabular Data Endpoints (TDE).
get_datastore_recordspages on the limit HDX applies. HDX lowers anylimitabove 32,000 to 32,000 and returns the value it used. Paging reads that value, so apage_sizeof 50,000 still yields every matching row.search_datastore_sqlwarns on a cut-off result. HDX stops a SQL result at 32,000 rows and setsrecords_truncated. The method logs a warning and returns the records it got.datastore_activetrue, give hdx@un.org for requests, and state the limit of 60 requests per minute per IP.search_datastore_sqldocuments the cap and the warning, linking GitBook's pagination guidance.limit, as CKAN 2.11 does. Both new cases fail onmainand pass here.test_resource.py25 passed, ruff clean. The 3test_update_logic.pyfailures need/tmp/WHO/health_indicators_ZMB.csvand fail the same way onmain.