Skip to content

[FIX] document_page: Fix page_id width in page history form view - #602

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
diggy128:18.0-document_page_view
Sep 1, 2026
Merged

[FIX] document_page: Fix page_id width in page history form view#602
OCA-git-bot merged 1 commit into
OCA:18.0from
diggy128:18.0-document_page_view

Conversation

@diggy128

@diggy128 diggy128 commented Mar 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Make page_id wider in history form view

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 26, 2026
@github-actions github-actions Bot closed this Aug 30, 2026
@diggy128

diggy128 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@etobella @victoralmau @mymage
Any chance to review / merge this?

@etobella etobella reopened this Aug 31, 2026
@etobella

etobella commented Aug 31, 2026

Copy link
Copy Markdown
Member

@diggy128 there is conflicts

@diggy128
diggy128 force-pushed the 18.0-document_page_view branch from f6c63d7 to bca8ede Compare August 31, 2026 19:04
@diggy128
[FIX] document_page: Fix display_name, page_id in page history
2f51090 
- Fix display_name for document.page.history
- Make page_id wider in history form view
@diggy128
diggy128 force-pushed the 18.0-document_page_view branch from bca8ede to 2f51090 Compare August 31, 2026 19:08
@diggy128

diggy128 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@etobella My branch was a little bit behind.
Fixing the conflicts, I found the history name was fixed in the meanwhile.
So this is just for the page_id width in the form view.

@diggy128 diggy128 changed the title [FIX] document_page: Fix display_name, page_id in page history [FIX] document_page: Fix page_id width in page history Aug 31, 2026
@diggy128 diggy128 changed the title [FIX] document_page: Fix page_id width in page history [FIX] document_page: Fix page_id width in page history form view Aug 31, 2026
etobella
etobella approved these changes Sep 1, 2026
View reviewed changes

@etobella etobella left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

To give a little context:

Before:

Image

After:

Image

@etobella

etobella commented Sep 1, 2026

Copy link
Copy Markdown
Member

/ocabot merge patch

Thanks @diggy128 and sorry for the delay on reviewing this.

@OCA-git-bot

OCA-git-bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-602-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit ec342a6 into OCA:18.0 Sep 1, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c6ea66a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza

pedrobaeza commented Sep 1, 2026

Copy link
Copy Markdown
Member

Should this be ported to 19.0?

@jans23 jans23 mentioned this pull request Sep 1, 2026
Merged
@jans23

jans23 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Forward port to 19.0: #639

@diggy128 diggy128 mentioned this pull request Sep 1, 2026
Closed
@diggy128
diggy128 deleted the 18.0-document_page_view branch September 1, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etobella etobella etobella approved these changes
+1 more reviewer
@victoralmau victoralmau victoralmau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:document_page Module document_page series:18.0 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@diggy128 @etobella @OCA-git-bot @pedrobaeza @jans23 @victoralmau