Repository navigation
build(deps): upgrade dependencies - #39
Merged
Merged
Conversation
- @deno/dnt 0.42.3 -> 0.43.2 - esbuild 0.25.12 -> 0.28.2 - @actions/core 1.11.1 -> 2.0.3 - @actions/exec and @actions/tool-cache stay on the latest CJS-compatible versions: 3.x/4.x are ESM-only and break the CommonJS bundle - drop the timers shim, removed in dnt 0.43
There was a problem hiding this comment.
Pull request overview
Upgrades the Deno + npm toolchain dependencies used to build and bundle this GitHub Action, including updating the DNT build script and regenerating lockfiles to match the new pinned versions.
Changes:
- Bump Deno import-map dependencies (
@deno/dnt,esbuild,@actions/core) to newer compatible versions. - Update the DNT bundling script to remove the removed
timersshim. - Regenerate
deno.lockandnpm/package-lock.jsonfor the updated dependency graph.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/bundle.ts | Removes the timers shim from the DNT build config. |
| deno.json | Updates import-map versions for DNT/esbuild/actions core. |
| deno.lock | Regenerates the Deno lockfile for updated jsr/npm dependencies. |
| npm/package-lock.json | Updates npm lockfile entries for the upgraded toolchain dependencies. |
Files not reviewed (1)
- npm/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Mixed registry URLs (registry.npmmirror.com) leaked in from the local ~/.npmrc during the dependency upgrade; regenerate all resolved URLs against registry.npmjs.org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrade the Deno/npm toolchain dependencies to their latest compatible versions.
Changes
@deno/dntesbuild@actions/core@actions/exec@actions/tool-cache@std/semver/octokitSupporting changes:
scripts/bundle.ts: drop thetimersshim, which was removed in dnt 0.43deno.lock,npm/package-lock.json, anddist/main.jsagainst the pinned versionsWhy
@actions/*stays on 2.x/1.x@actions/core@3.x,@actions/exec@3.x, and@actions/tool-cache@4.xare ESM-only packages (type: module,exportsonly expose animportcondition). The bundle pipeline emits CommonJS (npm/script/main.jsvia dnt), and esbuild cannot resolve arequire()of an ESM-only package —The path "." is not currently exported by package "@actions/core". The latest CJS-compatible versions are therefore kept until upstream restores CommonJS support (tracked in actions/toolkit#2294, actions/toolkit#2380).Verification
just cipasses locally (fmt, lint, check, bundle, andassert_unchangedall green)dist/main.jsdist/main.jssmoke-tested withnode dist/main.js(starts up correctly under a real action runtime)Notes
@actions/*majors will not merge; the ignore instructions were issued on the previous PR