Repository navigation
Authenticate the editorconfig-checker download - #3352
Merged
Merged
Conversation
The npm wrapper asks the GitHub API which release asset to fetch, and it builds its client with GITHUB_TOKEN. Without one the request is anonymous and shares a single rate limit with everything else running from the runner's address, so the step fails before it reads a file: GET /repos/editorconfig-checker/editorconfig-checker/releases/tags/v4.0.1 - 403 Failed to download binary: HttpError: API rate limit exceeded Hand it the workflow token, which carries its own limit. The job is advisory, so this failure cost no merge, but it reports red on unrelated pull requests and hides a real whitespace finding when there is one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm wrapper asks the GitHub API which release asset to fetch, and it builds its client with GITHUB_TOKEN. Without one the request is anonymous and shares a single rate limit with everything else running from the runner's address, so the step fails before it reads a file:
GET /repos/editorconfig-checker/editorconfig-checker/releases/tags/v4.0.1 - 403
Failed to download binary:
HttpError: API rate limit exceeded
Hand it the workflow token, which carries its own limit. The job is advisory, so this failure cost no merge, but it reports red on unrelated pull requests and hides a real whitespace finding when there is one.