Repository navigation
Say which class a refused cache file names - #3351
Merged
Merged
Conversation
A refused cache file is logged as "<file> names a class it may not hold", which leaves the reader to work out which class that was. The answer decides what to do about it: a class the stored object legitimately holds wants a cacheClasses() entry, and anything else wants not to be stored. log_history.dat was refused for the rCache its handler keeps in a property (Novik#3333), and the message said nothing about rCache. unserialize() leaves the original name in the stand-in object, so read it back and name it: "<file> names the class rCache, which it may not hold". The walk-budget test pinned the old wording to keep a class refusal distinguishable from a budget one; it now pins the class it named, which is the same distinction and a narrower assertion. Also adds the upgrade case Novik#3333 described but never exercised: a log_history.dat written with the pre-fix object graph is read back through the endpoint, with the handler and its cache both named in the file, the older message still in the answer and nothing refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refused cache file is logged as " names a class it may not hold", which leaves the reader to work out which class that was. The answer decides what to do about it: a class the stored object legitimately holds wants a cacheClasses() entry, and anything else wants not to be stored. log_history.dat was refused for the rCache its handler keeps in a property (#3333), and the message said nothing about rCache.
unserialize() leaves the original name in the stand-in object, so read it back and name it: " names the class rCache, which it may not hold".
The walk-budget test pinned the old wording to keep a class refusal distinguishable from a budget one; it now pins the class it named, which is the same distinction and a narrower assertion.
Also adds the upgrade case #3333 described but never exercised: a log_history.dat written with the pre-fix object graph is read back through the endpoint, with the handler and its cache both named in the file, the older message still in the answer and nothing refused.