tesla_preap: pedal chimes off gas override + opendbc #5 - #26
Merged
Merged
Conversation
Gas override drops interceptor authority while cruise stays on, so chimes keyed off pedalLongActive fired every press and release. Follow the cruise session instead, and loop the regen prompt until it clears.
Point opendbc_repo at the merge of NotAutopilot/opendbc#5 (3c4da443) so the pedal-chime / earlier-regen-prompt change tracks origin/opendbc nap-dev, not the pre-merge PR head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
promptRepeat) and tighten the demand check so the driver gets more time to add friction brake.opendbc_repoat3c4da443(merge of opendbc: regen prompt earlier + radar donor pin opendbc#5, regen prompt earlier + radar donor pin already used at604b9c).AGNOS stays 17.2. No 0.11.1 / AGNOS 18.4 stack.
Test plan