tesla: remove empty Pre-AP firmware candidate - #4
Merged
Merged
Conversation
Author
|
SloPOS: this is ready for the independent CODEOWNER/last-push review. The change removes only the empty Pre-AP firmware entry and keeps explicit Pre-AP selection intact. All required checks are green; focused verification is in the PR body. Please approve if it looks good. Once this merges, I will update openpilot#14 to the merged gitlink and request a fresh review there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the empty Tesla Pre-AP firmware table entry so exact firmware matching cannot select it vacuously. Preserve explicit Pre-AP selection and add regression coverage for normal firmware matching and Pre-AP interface parameters.
Verification: