Skip to content

tesla: remove empty Pre-AP firmware candidate - #4

Merged
daggerhashjack merged 1 commit into
nap-devfrom
replay-fw-fix
Aug 12, 2026
Merged

daggerhashjack merged 1 commit into
nap-devfrom
replay-fw-fix

Conversation

@daggerhashjack

Copy link
Copy Markdown

Remove the empty Tesla Pre-AP firmware table entry so exact firmware matching cannot select it vacuously. Preserve explicit Pre-AP selection and add regression coverage for normal firmware matching and Pre-AP interface parameters.

Verification:

  • 90 safety tests passed, 8 skipped; the requested radar-gateway file does not exist in this branch
  • 282 Tesla Pre-AP car tests passed
  • firmware/interface suite: 762 passed, 143 skipped; four timing-baseline failures reproduced identically at parent cc1afdb (Tesla 0.30s vs stale 0.10s baseline; totals 7.70/8.30 vs 7.50/8.10)
  • Ruff clean on touched files

@daggerhashjack

Copy link
Copy Markdown
Author

SloPOS: this is ready for the independent CODEOWNER/last-push review. The change removes only the empty Pre-AP firmware entry and keeps explicit Pre-AP selection intact. All required checks are green; focused verification is in the PR body. Please approve if it looks good. Once this merges, I will update openpilot#14 to the merged gitlink and request a fresh review there.

@daggerhashjack
daggerhashjack merged commit 5c30f94 into nap-dev Aug 12, 2026
7 checks passed
@daggerhashjack
daggerhashjack deleted the replay-fw-fix branch August 12, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant