planner: write the vector-primary key guard as is_none_or

[EnRaiha]

planner: write the vector-primary key guard as is_none_or

Why

cargo clippy -p nodedb --lib --all-features -- -D warnings fails on main at
nodedb/src/control/planner/sql_plan_convert/dml/vector_primary.rs:164:

error: this boolean expression can be simplified
   --> nodedb/src/control/planner/sql_plan_convert/dml/vector_primary.rs:164:16
    |
164 |               && !fields
165 | |                 .get(key_column)
166 | |                 .is_some_and(|v| !matches!(v, SqlValue::Null))
    | |______________________________________________________________^
    |
    = note: `-D clippy::nonminimal-bool` implied by `-D warnings`

No in-flight branch touches that line, so the lint gate blocks every unrelated review. This
change applies clippy's own rewrite.

What changed

One file, +109/-2 against main:

• nodedb/src/control/planner/sql_plan_convert/dml/vector_primary.rs — the key-column guard
  written in clippy's suggested form, plus four tests in its mod tests that pin the
  key-column fill rule.

The new spelling is the negation identity is_none_or(f) == !is_some_and(!f), so the guard
selects the same rows: a row gets a minted identity exactly when the key column is absent or
NULL.

if !is_auto_rowid_pk(primary_key)
    && fields
        .get(key_column)
        .is_none_or(|v| matches!(v, SqlValue::Null))

Effect

No user-visible change. The planner builds the same plan for the same statement: no wire,
SQL, error-code, metric, config or on-disk change. is_none_or needs Rust 1.82 and the
workspace sets rust-version = "1.94", so the toolchain floor does not move either.

Steps to test

cargo clippy --workspace --all-targets --all-features --profile ci -- -D warnings   # exit 0
cargo nextest run -p nodedb --lib -E 'test(~key_column)'                            # 5 passed

The first command is the CI gate verbatim. The failing state reproduces at main: the same
clippy command exits 101 with the diagnostic quoted in Why.

Checks

step	command	exit	at
red	cargo clippy -p nodedb --lib --all-features -- -D warnings	101	main (f18b31edf)
green	cargo clippy -p nodedb --lib --all-features -- -D warnings	0	77cb53893
green	cargo nextest run -p nodedb --lib -E 'test(~key_column)'	0 · 5 passed	77cb53893
green	cargo clippy --workspace --all-targets --all-features --profile ci -- -D warnings	0	77cb53893
assertion strength	cargo nextest run -p nodedb --lib -E 'test(~key_column)', guard removed	100 · 3 passed, 2 failed	77cb53893 plus the guard removed

The last row is what makes the tests evidence: with the guard removed, the two fill cases
fail, so they cover the guard's behaviour and not only that the file compiles. The base
predicate passes the same five tests, so no case is red on main.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.