Conversation
Tbaile
force-pushed
the
user-pass-conroller
branch
from
September 22, 2026 11:46
6f8caad to
fc206a4
Compare
Tbaile
force-pushed
the
user-pass-conroller
branch
from
September 22, 2026 11:53
fc206a4 to
a0501f0
Compare
Tbaile
marked this pull request as ready for review
September 22, 2026 11:57
gsanchietti
reviewed
Sep 24, 2026
| } | ||
|
|
||
| // control characters would let a crafted name forge extra log lines | ||
| if strings.ContainsFunc(onBehalfOf, func(r rune) bool { return r < 0x20 || r == 0x7f }) { |
Member
There was a problem hiding this comment.
I'd move to a regexp validation since onBehakfOf is always a unix-like user: something like regexp.MustCompile(^[A-Za-z0-9._@-]+$)
| } | ||
|
|
||
| if user.SudoRequested { | ||
| claims["sudo"] = time.Now().Unix() |
Member
There was a problem hiding this comment.
Do you think it could be useful to log the sudo request?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`POST /login` now accepts an optional `on_behalf_of` field, accepted only from the controller machine account, carried in the JWT and appended to the `[AUTH]` log lines as the delegated operator.
Needs: NethServer/nethsecurity-controller#293
Closes: #1894
Description generated with Claude Code