Nextcloud keeps restarting if configured without the email option

[DavidePrincipi]

Steps to reproduce

• Install Nextcloud 1.7.5.
• Configure it from the command line and leave out the internal_smarthost option (the "Manage email sending from Nextcloud admin panel" setting of the web interface), for example: api-cli run module/nextcloud1/configure-module --data '{"host": "nextcloud.example.org", "lets_encrypt": false, "domain": "", "password": "Nethesis,1234"}'

Expected behavior

Nextcloud is never left restarting: either the configuration completes and Nextcloud runs, or the request is rejected with a clear error message.

Actual behavior

Nextcloud never finishes starting: the nextcloud-app service restarts over and over, and the system log shows a KeyError: 'internal_smarthost' error from the email setup step (setup-smtp).

Configuring Nextcloud from the web interface is not affected, because it always sends the option.

Components

• Nextcloud module (ns8-nextcloud) 1.7.5

See also

• Smarthost Handling Between Cluster and Nextcloud #7871, the feature that added the option
• fix: require the internal_smarthost attribute ns8-nextcloud#269, the proposed fix