Repository navigation
build(deps): bump dompurify from 3.4.11 to 3.4.17 - #231
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.11 to 3.4.17. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.11...3.4.17) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.17 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
Looks like dompurify is up-to-date now, so this is no longer needed. |
🤖 Codex-Style Code Review by OpenCode (Vue Best Practice Enabled)
Code Review Report — PR:
|
| Item | Detail |
|---|---|
| Type | Automated dependency bump (Dependabot) |
| Changed files | package-lock.json only (1 file, ±3 lines) |
| Dependency | dompurify 3.4.11 → 3.4.17 |
| Dependency kind | Indirect (transitive via mermaid), not declared in package.json |
| Source code changes | None |
The branch commit (cf1daee) only updates three lockfile fields for node_modules/dompurify: version, resolved, and integrity.
🔴 Critical Finding: The PR is a no-op
The merge commit's tree is byte-identical to its first parent 88701b6:
HEAD^{tree} = 315a16c7f2cb8e6d13ee72bb3cc0291cc04f4bc0
88701b6^{tree} = 315a16c7f2cb8e6d13ee72bb3cc0291cc04f4bc0 ← identical
git diff origin/main...HEAD produces no output — the effective diff against the merge base is empty.
Why: The base already absorbed this bump. PR #229 (88701b6, katex + mermaid bump) regenerated the lockfile, which pulled mermaid's transitive dompurify range from ^3.3.3 up to ^3.4.12 and resolved it to 3.4.17 — the exact version this PR targets:
// origin/main package-lock.json (already present)
"node_modules/dompurify": {
"version": "3.4.17", // ← already at target version on main
...
}Dependabot opened this PR from a stale base (2de50fe) before #229 landed. Merging it changes nothing.
Assessment
✅ Correct
- Integrity hash and registry URL for 3.4.17 are legitimate.
- Bumping DOMPurify is security-relevant hygiene: mermaid relies on it to sanitize rendered diagram HTML used in
src/views/Editor.vueandsrc/views/ExperimentSummary.vue. (No directDOMPurifyimport exists insrc/— purely transitive.)
⚠️ Concerns
- Redundant merge commit — merging this PR adds a permanent no-op merge commit (
cb91266) to history, which can confusegit bisectruns and blame tooling for zero benefit. - Stale base — Dependabot's branch was cut from
2de50fe; it should be rebased/closed rather than merged.
Vue 3 / Code Quality
Not applicable — no .vue, .ts, or application code touched. No Composition API, reactivity, lifecycle, or typing concerns arise from this change.
Recommendation
Close this PR (reason: "already satisfied by #229"). origin/main already resolves dompurify@3.4.17; the lockfile on main is identical to what this PR would produce. No action needed on the dependency itself.
If the project prefers Dependabot PRs to be merged rather than closed, merging is technically harmless (clean merge, empty resulting diff), but it should not be squashed-with-title since the title would imply a bump that doesn't occur in the resulting tree.
Bumps dompurify from 3.4.11 to 3.4.17.
Release notes
Sourced from dompurify's releases.
Commits
a77a3e7release: 3.4.17 (#1672)b9b9d80release: 3.4.16 (#1636)1d7460crelease: 3.4.15 (#1609)4e6fe24release: 3.4.14 (#1587)3067f77release: 3.4.13 (#1562)a9ca1e5release: 3.4.12 (#1537)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.