Skip to content

feat(runtime): add nullability annotations to NativeScript.h #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrian-niculescu wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −4
Open

feat(runtime): add nullability annotations to NativeScript.h #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02c8e4
feat(runtime): add nullability annotations to NativeScript.h
adrian-niculescu Aug 28, 2026
ae42f48
fix(runtime): read no inspector flags from a nil Arguments array
adrian-niculescu Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions NativeScript/NativeScript.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
#import <Foundation/Foundation.h>

NS_ASSUME_NONNULL_BEGIN

@interface Config : NSObject

@property (nonatomic, retain) NSString* BaseDir;
@property (nonatomic, retain) NSString* ApplicationPath;
@property (nonatomic) void* MetadataPtr;
@property (nonatomic, retain, nullable) NSString* ApplicationPath;
@property (nonatomic, nullable) void* MetadataPtr;
@property BOOL IsDebug;
@property BOOL LogToSystemConsole;
@property int ArgumentsCount;
@property (nonatomic) char** Arguments;
@property (nonatomic) char* _Nullable* _Nullable Arguments;
Comment thread
coderabbitai[bot] marked this conversation as resolved.

@end

Expand All @@ -26,3 +28,5 @@
- (bool)liveSync;

@end

NS_ASSUME_NONNULL_END
4 changes: 3 additions & 1 deletion NativeScript/inspector/JsV8InspectorClient.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ bool ShouldRewriteSourceMapURLs() {

notify_post(NOTIFICATION("AppLaunching"));

for (int i = 1; i < argc; i++) {
// A nil Arguments array carries no flags whatever ArgumentsCount says, and a
// null element ends the list the way it does in a C argv.
for (int i = 1; argv != nullptr && i < argc && argv[i] != nullptr; i++) {
BOOL startListening = NO;
BOOL shouldWaitForDebugger = NO;

Expand Down
Loading