Skip to content

fix(cuda-oxide): reject failed WGMMA PTX smoketest fallbacks - #1444

Open
pedrozaz wants to merge 1 commit into
NVIDIA:mainfrom
pedrozaz:fix/wgmma-smoketest-verdict
Open

pedrozaz wants to merge 1 commit into
NVIDIA:mainfrom
pedrozaz:fix/wgmma-smoketest-verdict

Conversation

@pedrozaz

@pedrozaz pedrozaz commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The WGMMA PTX fallback could report PASS after a failed Cargo run or when the expected PTX was missing or empty. Require a successful run and a nonempty artifact before accepting the fallback.

Fixes #1414

Changes

  • Check Cargo exit status before accepting the WGMMA fallback.
  • Require nonempty PTX before the optional ptxas gate.
  • Add CPU-only regression tests for verdicts and the runner's failure summary and exit status.
  • Preserve tolerated non-Hopper PTX load failures and missing/old ptxas skips.

Testing

bash cuda-oxide/scripts/check-example-smoketest-contract.sh passed:

OK: 13 WGMMA verdict cases and failed-run summary/exit status.

Bash syntax, SPDX headers, and git diff --check also passed. In temporary copies, the tests rejected the original bug and removal of either new check.

  • just -f cuda-oxide/Justfile check passes
  • cargo oxide run wgmma or GPU smoketest passes

Require a successful Cargo run and nonempty expected PTX before accepting
non-Hopper fallbacks. Preserve optional ptxas skips and tolerated PTX load
failures.

Add CPU-only regression coverage for the verdicts and the runner summary
and exit status.

Signed-off-by: Guilherme Pedroza <guilhermebarb0sa@proton.me>
@pedrozaz
pedrozaz requested a review from nihalpasham as a code owner October 8, 2026 01:03
Copilot AI balanced review requested due to automatic review settings October 8, 2026 01:03
@copy-pr-bot

copy-pr-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@pedrozaz pedrozaz changed the title fix: reject failed WGMMA PTX smoketest fallbacks fix(smoketest): reject failed WGMMA PTX fallbacks Oct 8, 2026
@pedrozaz

pedrozaz commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Local validation: just -f cuda-oxide/Justfile check passed (exit code 0).

@pedrozaz

pedrozaz commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

WGMMA smoketest passed on NVIDIA GeForce RTX 5060 Ti (sm_120).

  • Command, from cuda-oxide/: bash scripts/smoketest.sh -o '^wgmma$' --no-color --keep-logs
  • Result: PASS (wgmma, PTX compiled; ptxas sm_90a ok)
  • Summary: 1 passed, 0 failed.
  • Exit code: 0.

This validates the non-Hopper PTX fallback and ptxas assembly.

@pedrozaz pedrozaz closed this Oct 8, 2026
@pedrozaz

pedrozaz commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

I forgot the contribution PRs were paused, I'm sorry.

@pedrozaz pedrozaz reopened this Oct 11, 2026
@pedrozaz pedrozaz changed the title fix(smoketest): reject failed WGMMA PTX fallbacks fix(cuda-oxide): reject failed WGMMA PTX smoketest fallbacks Oct 11, 2026
@nihalpasham nihalpasham added the cuda-oxide SIMT programming model: rustc backend, cargo oxide, cuda-device, cuda-host, book label Oct 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda-oxide SIMT programming model: rustc backend, cargo oxide, cuda-device, cuda-host, book

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: WGMMA smoketest reports PASS after failure with missing PTX

4 participants