Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to
|
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3166.
Skip only
test_discover_gpuswhen the process runs on Linux without root privileges. The NVML PCI rediscovery operation is documented as requiring administrator privileges; ordinary GPU enumeration and CUDA execution do not require this operation.Observed during Linux ARM64 GB10 non-root container testing: this test raises
nvml.UnknownError. The existingOperatingSystemErrorsuppression does not cover it. An explicit privilege guard avoids broadly suppressing genuine driver errors.Root Linux processes retain the existing test behavior. Windows does not evaluate
os.geteuid()because the condition short-circuits. No other NVML test or production binding changes.Validation
pytest -v -rs cuda_bindings/tests/nvml/test_pci.py: 2 passed, 2 skipped (the discovery test skips for non-root; one unrelated unsupported bridge-info subtest also skips).geteuid.git diff --checkpassed.cuda-bindings 13.4.2.dev243+gf9de5797ewheel environment. No new source build or GB10 rerun for this public branch.Checklist