Skip to content

Don't block on API changes vs. the merge base of a PR #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdboom wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Don't block on API changes vs. the merge base of a PR #2798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f3a03d
Don't block on API changes vs. the merge base of a PR
mdboom Sep 9, 2026
dc3c249
Merge branch 'main' into loosen-abi-breakage
mdboom Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,8 +697,8 @@ jobs:
if [[ "$run_core_api_check" == "true" ]]; then expected="success"; fi
check_result "api-check-core-vs-release" "$expected"

expected="skipped"
if [[ "$is_pr" == "true" && "$run_core_api_check" == "true" ]]; then expected="success"; fi
check_result "api-check-core-vs-base" "$expected"
# API compatibility checks against the merge base (api-check-core-vs-base)
# are purely informational, since it is fine for API to drift during development
# when it hasn't been released yet.

[[ "$status" == "success" ]]
Loading