Skip to content

fix(providers): keep OpenCode's internal plugins so OAuth logins work #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rng1995 merged 2 commits into from
Oct 14, 2026
Merged

fix(providers): keep OpenCode's internal plugins so OAuth logins work #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc9c17
fix(providers): keep OpenCode's internal plugins so OAuth logins work
elliottwaves-20 Oct 8, 2026
22cec46
docs(providers): describe the plugin scope precisely and pin the env …
elliottwaves-20 Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/skillspector/providers/_agent_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,10 @@ def _prepare_opencode_env(
independently as defense in depth.

The real OpenCode authentication store remains available so this CLI
provider can use the user's existing login. All mutable config, cache,
provider can use the user's existing login. OpenCode's internal plugins stay
enabled for the same reason: they implement the OAuth logins (ChatGPT,
Copilot, GitLab, ...) and register no tools. External plugins remain off
through ``--pure`` / ``OPENCODE_PURE``. All mutable config, cache,
state, database, and temporary paths are redirected below the invocation's
already-isolated temporary root.
"""
Expand Down Expand Up @@ -536,7 +539,6 @@ def _prepare_opencode_env(
"OPENCODE_DISABLE_AUTOCOMPACT": "1",
"OPENCODE_DISABLE_AUTOUPDATE": "1",
"OPENCODE_DISABLE_CLAUDE_CODE": "1",
"OPENCODE_DISABLE_DEFAULT_PLUGINS": "1",
"OPENCODE_DISABLE_EXTERNAL_SKILLS": "1",
"OPENCODE_DISABLE_LSP_DOWNLOAD": "1",
"OPENCODE_DISABLE_MODELS_FETCH": "1",
Expand Down Expand Up @@ -674,7 +676,9 @@ def _build_opencode_argv(binary: str, model: str, max_output_tokens: int = 0) ->
SKILLSPECTOR_MODEL is set).

The shared runner also isolates every OpenCode config/state path, disables
ambient instructions, skills, plugins, auto-sharing, snapshots and updates,
ambient instructions, skills, external plugins (the internal OAuth/provider
plugins stay enabled, see ``_prepare_opencode_env``), auto-sharing,
snapshots and updates,
scrubs secret-bearing environment variables, delivers untrusted content
via stdin only, and never passes ``--auto``.

Expand Down
7 changes: 6 additions & 1 deletion tests/provider/test_opencode_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ def test_policy_overrides_hostile_ambient_configuration(self, tmp_path: Path) ->
"OPENCODE_CONFIG_CONTENT": '{"permission":"allow","share":"auto"}',
"OPENCODE_PERMISSION": '{"*":"allow"}',
"OPENCODE_EXPERIMENTAL": "1",
# An ambient value must not switch the OAuth login plugins back off (#809).
"OPENCODE_DISABLE_DEFAULT_PLUGINS": "1",
}

argv = _build_opencode_argv(OPENCODE_BINARY, "", 0)
Expand All @@ -317,7 +319,10 @@ def test_policy_overrides_hostile_ambient_configuration(self, tmp_path: Path) ->
assert config["autoshare"] is False
assert env["OPENCODE_AUTO_SHARE"] == "0"
assert env["OPENCODE_DISABLE_PROJECT_CONFIG"] == "1"
assert env["OPENCODE_DISABLE_DEFAULT_PLUGINS"] == "1"
# Internal plugins carry the OAuth logins (ChatGPT, Copilot, ...) and
# register no tools; disabling them breaks the user's login (#809).
# External plugins stay off through OPENCODE_PURE below.
assert "OPENCODE_DISABLE_DEFAULT_PLUGINS" not in env
assert env["OPENCODE_DISABLE_EXTERNAL_SKILLS"] == "1"
assert env["OPENCODE_DISABLE_CLAUDE_CODE"] == "1"
assert env["OPENCODE_PURE"] == "1"
Expand Down
Loading