Repository navigation
Conversation
…ance Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kubernetes conformance currently starts when the gateway connects, even if Agent Sandbox is still recovering after guest boot. This can fail the first sandbox creation before its scenario assertions run. Wait for controller-owned Pod creation before starting conformance, and preserve controller startup evidence when preparation or tests fail.
Related Issue
Closes #4675.
Changes
Testing
nix run .#tmachine -- test ubuntu-k3s k3s conformance: all eight archived tests passed in 298.4 seconds on an ARM64 Ubuntu 24.04 guest, K3s 1.29.15, and Agent Sandbox 0.5.0. Runtime artifacts came frombe9d7a0561cfd55b1ca426f0217e283a4e28b6b8; the conformance sources match this branch. The probe waited 10.9 seconds through real controller recovery, then cleaned up.mise run pre-commit.mise run ci: failed in the unchanged VM-driver testdriver::tests::stopping_a_sandbox_lets_the_supervisor_drain_before_closing_liveness, at the fixture'schild.try_wait().unwrap().is_none()assertion. The test also failed when rerun alone. This PR does not modify VM-driver code.The local VM reproduced a controller startup certificate error followed by restart and leader election. It does not establish the original CI failure's exact cause. Original CI used x86-64; local VM validation used ARM64.
Checklist