Repository navigation
test(sandbox): isolate landlock fd limit test - #4456
Closed
ericcurtin wants to merge 1 commit into
Closed
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@drew @johntmyers PTAL when you get a chance, and |
Collaborator
|
dupe of #4457 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Landlock fd regression test deterministic by running it in a subprocess with a low fd limit.
Related Issue
Closes #4455
Changes
/proc/self/fdcount, which saw fds from parallel tests, with a subprocess that lowersRLIMIT_NOFILEbelow the entry count.prepare_capability_free_baseline_atinstead of only the entry iterator.require_abi()for the ABI skip check.Testing
cargo fmt,cargo clippy -p openshell-sandbox --all-targets -D warnings, andcargo test -p openshell-sandbox --lib(3 runs, 244 passed). Collecting all entry fds up front makes the test fail with EMFILE.Checklist