Skip to content

test(sandbox): isolate landlock fd limit test - #4456

Closed
ericcurtin wants to merge 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/4455-landlock-fd-test/ericcurtin
Closed

ericcurtin wants to merge 1 commit into
NVIDIA:mainfrom
ericcurtin:fix/4455-landlock-fd-test/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

Make the Landlock fd regression test deterministic by running it in a subprocess with a low fd limit.

Related Issue

Closes #4455

Changes

  • Replace the /proc/self/fd count, which saw fds from parallel tests, with a subprocess that lowers RLIMIT_NOFILE below the entry count.
  • Run the real prepare_capability_free_baseline_at instead of only the entry iterator.
  • Reuse require_abi() for the ABI skip check.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

cargo fmt, cargo clippy -p openshell-sandbox --all-targets -D warnings, and cargo test -p openshell-sandbox --lib (3 runs, 244 passed). Collecting all entry fds up front makes the test fail with EMFILE.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@drew @johntmyers PTAL when you get a chance, and /ok to test cd54555d7b7e670030ebdb7c0d8e4d2f7dc54efd if it looks good. Thank you!

@johntmyers

Copy link
Copy Markdown
Collaborator

dupe of #4457

@johntmyers johntmyers closed this Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Landlock descriptor regression test fails intermittently during parallel CI runs

2 participants