Repository navigation
ci: require accepted issues for community pull requests - #4340
Merged
Merged
Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 8, 2026 14:58
Collaborator
|
overall this lgtm just gotta get zizmor happy (prob safe to ignore the one finding?) |
elezar
force-pushed
the
ci/4339-pr-issue-acceptance/elezar
branch
from
October 12, 2026 20:12
678d492 to
52ae70d
Compare
alangou
reviewed
Oct 13, 2026
alangou
reviewed
Oct 13, 2026
elezar
force-pushed
the
ci/4339-pr-issue-acceptance/elezar
branch
from
October 13, 2026 10:10
6f6fd11 to
0dd0235
Compare
Evaluate issue acceptance using trusted default-branch code and the PR author's repository permissions. Report the native workflow job result, protect enforcement files, and align PR creation and review guidance. Closes #4339 Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
ci/4339-pr-issue-acceptance/elezar
branch
from
October 13, 2026 10:12
0dd0235 to
c042e33
Compare
alangou
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require community pull requests to link OpenShell issues marked
state:accepted, while allowing authors with verified repository write access to proceed without that label. Report acceptance through the nativeOpenShell / PR Issue AcceptanceActions job, including fork PRs and drafts, and prevent PR body text from granting an exemption.Related Issue
Closes #4339
The issue does not have
state:accepted; the submitting author's verified repository admin access permits this PR under the maintainer exception.Changes
pull_request_targetworkflow that loads trusted base code and runs the CJS check alongside the existing maintainer-check scripts intasks/scripts/.pull_request_targettrigger in Zizmor. Native required code-owner review must be enabled for ownership to enforce approval.statuses: write. Lookup errors propagate to the job, including a failed PR refresh; checkout and script-loading failures also fail the job. NeitherNo issue requirednor the triggering actor's permissions bypasses acceptance.Testing
mise run pre-commit, Actionlint and offline Zizmor for the acceptance workflow (the three workflows were also checked before rebasing), skill validation, inventory and architecture cross-reference checks, trusted workflow wiring, andgit diff --check.node --test tasks/scripts/check_issue_acceptance.test.cjs— all 16 pass, covering independent evaluations for shared-head PRs, failed refreshes after success, and PR/issue/label lookup failures; the 19 maintainer-helper tests also pass after integrating feat(ci): gate merges on maintainer approval via a required status check #3176.mise run ciwas attempted but stopped during Rust test linking withld: library 'z3' not foundinopenshell-prover-cli. This PR changes no Rust code. Hosted verification of this workflow, including two PRs sharing a head commit and fork behavior, remains pending: it requires a sandbox default branch or deployment of the trusted workflow and script. Local shared-head regression tests exercise independent evaluations, not GitHub's check association.Checklist