Repository navigation
docs(sandboxes): add IPv6 loopback example to Port Forwarding - #2449
Conversation
|
All contributors have signed the DCO ✍️ ✅ |
|
I have read the DCO document and I hereby sign the DCO. |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This is a project-valid, concentrated core bug fix. It restores valid OpenSSH and URL formatting for an IPv6 bind address; PR #2409 was the same author's earlier submission and was closed only by the vouch gate.
Head SHA: bc87935b91607195c7c6b5e281a78e8b55b7cbc8
Review findings:
- The focused implementation and regression tests are sound; no correctness or security defect was found.
- The new helper leaves identical IPv6-bracketing logic in
format_gateway_url(); the inline suggestion asks to consolidate that logic so the two paths cannot drift. - This changes direct user-visible forwarding behavior and printed access URLs. Please add an IPv6 example to the existing Port Forwarding section in
docs/sandboxes/manage-sandboxes.mdx, including the bracketedhttp://[::1]:8000/output. Existing navigation already covers that page, sodocs/index.ymldoes not need to change.
Docs: missing for this direct UX change.
E2E/pipeline: deferred until review feedback is resolved.
Next state: gator:in-review
… forwarding Addresses gator-agent review feedback on NVIDIA#2449: - Consolidate IPv6 bracketing by having format_gateway_url() call bracket_ipv6(). - Add an IPv6 loopback example to the Port Forwarding docs section showing the bracketed http://[::1]:8000/ URL. Signed-off-by: Andrew White <andrewh@cdw.com>
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This remains a project-valid, concentrated core bug fix for invalid IPv6 formatting in OpenSSH forward arguments and printed access URLs.
Head SHA: e28f49ccdda1e6cec0ce9dd0c1fd51d2537262c9
Thanks @andrewwhitecdw. I checked the latest commit against both prior requests: consolidating IPv6 bracketing through bracket_ipv6() is resolved, and the requested Fern page now includes an IPv6 example. The code and focused regression coverage are sound, with no correctness or security defect found.
Review findings:
- The new documentation command uses a flag that
openshell forward startdoes not support; the inline warning gives the valid positional syntax.
Docs: the existing page and navigation location are correct, but the example command must be fixed.
E2E/pipeline: deferred until this review finding is resolved.
Next state: gator:in-review
|
Fixed — the example now uses the positional |
BlockedHead SHA: 8581114 Thanks @andrewwhitecdw. I checked your update: the IPv6 documentation example now uses the valid positional [bind_address:]port form, and the earlier documentation review finding is resolved. Gator is blocked because this PR currently has merge conflicts with main. Next action: rebase or merge main into the PR branch, resolve the conflicts, and push the updated head. Gator will re-review the new head before starting the pipeline. |
8581114 to
f684685
Compare
… forwarding Addresses gator-agent review feedback on NVIDIA#2449: - Consolidate IPv6 bracketing by having format_gateway_url() call bracket_ipv6(). - Add an IPv6 loopback example to the Port Forwarding docs section showing the bracketed http://[::1]:8000/ URL. Signed-off-by: Andrew White <andrewh@cdw.com>
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Validation: This remains a project-valid, concentrated IPv6 forwarding documentation fix. The equivalent core behavior is now present on main, so the rebased effective patch is the focused user-facing example.
Head SHA: f684685195de861ed1d48544ada4acd5fbb54e2c
Base SHA: 28f3bee0ce7e89c845016fc0554f8990a31543bb
Merge base SHA: 28f3bee0ce7e89c845016fc0554f8990a31543bb
Patch ID: 77adeb1e5b3f916f9ddaa3c25e6871176469df6f
Gator payload: 2
Review mode: follow_up
Previous reviewed SHA: e28f49ccdda1e6cec0ce9dd0c1fd51d2537262c9
Thanks @andrewwhitecdw. I checked the rebased head and your corrected positional [bind_address:]port example. The prior documentation warning remains resolved, and the old merge-conflict blocker is cleared.
Blocking findings:
- No blocking findings remain.
Carried findings:
- None; the prior consolidation and documentation obligations remain resolved.
Docs: the existing Fern page now shows the valid IPv6 command and bracketed access URL; existing navigation already covers it.
E2E: no test:e2e label is needed for the current docs-only effective patch. Branch Checks and Helm Lint still require the current-head copy-pr mirror.
Next state: gator:watch-pipeline
|
/ok to test f684685 |
… forwarding Addresses gator-agent review feedback on NVIDIA#2449: - Consolidate IPv6 bracketing by having format_gateway_url() call bracket_ipv6(). - Add an IPv6 loopback example to the Port Forwarding docs section showing the bracketed http://[::1]:8000/ URL. Signed-off-by: Andrew White <andrewh@cdw.com> Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
f684685 to
5878faf
Compare
|
This pull request has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity. |
|
Thanks @johntmyers — this PR is up to date on review feedback:
Apologies for the churn from the accidental close earlier. No pending review items remain on my side — happy to address anything else, and please let me know if you'd rather I rebase onto current |
|
This pull request has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity. |
|
Bumping this to keep it from going stale — still actively engaged and the branch remains ready for review. All prior review feedback is addressed in the current head (shared |
|
This pull request has had no activity for 14 days and is now marked stale. It may be closed in 7 days if there is no further activity. |
Relevance AssessmentPartially applicable: the original code fix has landed; the IPv6 documentation example remains useful and missing from current main. I compared freshly fetched main Thanks @andrewwhitecdw. I checked your September updates about the shared helper, corrected positional command, and resolved review feedback. Both earlier Gator threads remain resolved; the current effective patch matches the last reviewed patch, so those obligations stay resolved without another review of unchanged code.
Action required: @andrewwhitecdw, rebase onto current main, resolve the conflicts by carrying only the IPv6 example into the current Port Forwarding section, and preserve the newer documentation around it. Retitle the PR to reflect its remaining documentation scope; no replacement core fix is needed. Gator will reconcile the updated patch and required current-head checks afterward. Runtime E2E is unnecessary for the existing docs-only patch; pipeline handoff remains deferred while merge conflicts persist. Gator metadata
|
The core IPv6 forwarding fix landed on main via NVIDIA#2552; this carries the docs example forward into the current Port Forwarding section of docs/how-it-works/sandboxes/overview.mdx after the page move in NVIDIA#3705. Remaining scope is documentation only. Signed-off-by: Andrew White <andrewh@cdw.com>
5878faf to
ea93e41
Compare
|
Done — rebased onto current main and retitled.
Gator should be able to reconcile the updated patch now. |
|
/ok to test ea93e41 |
PR Review StatusThanks @andrewwhitecdw. I checked your rebase and retitle: the remaining eight added lines place the valid positional IPv6 command and bracketed URL in the current Port Forwarding section, preserving the newer multiplexing and foreground text. Merge conflicts are cleared. The independent follow-up review found no blocking defects; both earlier Gator findings remain resolved. The existing relevance assessment still holds against freshly fetched main Action required: @andrewwhitecdw and a maintainer, link an issue covering this remaining documentation work with I posted Gator metadata
|
|
Issue linkage done:
@johntmyers — over to you for the |
Monitoring CompleteMonitoring is complete because PR #2449 merged at 2026-10-14 00:08:53 UTC. The IPv6 loopback documentation example landed in Thanks @andrewwhitecdw. I confirmed your docs-only rebase, revised description, and I removed the active Gator metadata
|
Summary
Adds the missing IPv6 loopback example to the Port Forwarding documentation. The core behavior this example demonstrates already landed on main via #2552 (bracketed SSH bind argument and access URL, closing #2279); after #3705 moved the page, the current Port Forwarding section at
docs/how-it-works/sandboxes/overview.mdxonly shows the IPv4 form. This PR supplies the IPv6 example there — documentation only, no code changes.openshell forward start ::1:8000 my-sandbox # Local URL: http://[::1]:8000/Related Issue
Fixes #4504
Changes
[bind_address:]portform, bracketed access URL) to the Port Forwarding section ofdocs/how-it-works/sandboxes/overview.mdxTesting
Checklist