Skip to content

fix: describe missing v1 response fields - #180

Merged
MrRefactoring merged 1 commit into
masterfrom
fix/v1-schema-drift
Oct 13, 2026
Merged

MrRefactoring merged 1 commit into
masterfrom
fix/v1-schema-drift

Conversation

@MrRefactoring

@MrRefactoring MrRefactoring commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

The v1 schema audit reports three undocumented response paths across five endpoints even though all 493 live tests pass. These paths correspond to two missing properties: the PDF export styling preference in space settings and attachment comments in content metadata.

Add optional SpaceSettings.isPdfExportNoCodeStylingOptedIn: boolean and ContentMetadata.comment: string through the existing Confluence generator patch table. Regenerate the two SDK models, preserve existing contracts, and add a patch changeset for 3.3.1.

  • Generator source: MrRefactoring/apis-code-gen@45f20d339f0d6b1751765b091948091717c14466, pushed to master. No shared generator/core behavior changes.
  • Add 16 regression cases in strict audit mode for optionality, output types, booleans, empty/Unicode comments and invalid values.
  • Assert the response fields in existing live tests for all three attachment upload operations and space settings. Confluence omits empty attachment comments, while nonempty comments are returned verbatim; existing version metadata read-back assertions remain intact.

Validation:

  • Generator typecheck and 440 tests passed.

  • SDK lint, typecheck, build and 220 unit tests passed.

  • Compatibility against v3.3.0 passed for 737 parameter/response types and 348 endpoint signatures.

  • attw and packed-package node-esm, ts-strict and ts-bundler consumers passed.

  • Full strict schema audit: 493/493 tests, 56/56 files, zero undocumented fields and zero grown enums (373.11s).

  • All seven GitHub checks passed on 50dea779a6d678885aba1212128e7cd59e6dc232, including the complete Node.js 22 live suite: 493/493 tests, 56/56 files, no skips (run).

Source report: https://github.com/MrRefactoring/confluence.js/actions/runs/38390210645/job/115271864428

@MrRefactoring
MrRefactoring merged commit 6036749 into master Oct 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant