Repository navigation
fix: describe missing v1 response fields - #180
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1 schema audit reports three undocumented response paths across five endpoints even though all 493 live tests pass. These paths correspond to two missing properties: the PDF export styling preference in space settings and attachment comments in content metadata.
Add optional
SpaceSettings.isPdfExportNoCodeStylingOptedIn: booleanandContentMetadata.comment: stringthrough the existing Confluence generator patch table. Regenerate the two SDK models, preserve existing contracts, and add a patch changeset for 3.3.1.Validation:
Generator typecheck and 440 tests passed.
SDK lint, typecheck, build and 220 unit tests passed.
Compatibility against v3.3.0 passed for 737 parameter/response types and 348 endpoint signatures.
attw and packed-package node-esm, ts-strict and ts-bundler consumers passed.
Full strict schema audit: 493/493 tests, 56/56 files, zero undocumented fields and zero grown enums (373.11s).
All seven GitHub checks passed on
50dea779a6d678885aba1212128e7cd59e6dc232, including the complete Node.js 22 live suite: 493/493 tests, 56/56 files, no skips (run).Source report: https://github.com/MrRefactoring/confluence.js/actions/runs/38390210645/job/115271864428