Repository navigation
Record the value size and copy functions of a pose chain and a raster in the Spark gaps ledger - #175
Merged
estebanzimanyi merged 1 commit intoOct 11, 2026
Conversation
… in the Spark gaps ledger MobilityDB b2dcdf7d84 makes public the size and the copy of every value type, the first step of a binding carrying a value as its MEOS memory image: posechain_mem_size takes a PoseChain *, raster_mem_size a Raster * and raster_copy returns one, which the Spark UDF surface does not carry, as for the functions the ledger lists with that argument or return. tools/spark-udf-gaps.txt lists the three; the other size and copy functions it makes public reach the surface. Witness: over MobilityDB b2dcdf7d84 and MEOS-API 9b337a00fe the step refusing a public function the Spark surface stops reaching fails on main's ledger with "3 public functions the surface does not reach and the ledger does not list", naming posechain_mem_size arg:PoseChain *, raster_copy ret:Raster * and raster_mem_size arg:Raster *. Measured over the same pair with the jar built from that catalog and that libmeos: the step reports no function missing from the ledger, which lists 758 functions. Why: the ledger states every public function the Spark UDF surface does not reach, so a catalog change that leaves one unmapped is refused instead of passing in silence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobilityDB b2dcdf7d84 makes public the size and the copy of every value type, the first step of a
binding carrying a value as its MEOS memory image: posechain_mem_size takes a PoseChain *,
raster_mem_size a Raster * and raster_copy returns one, which the Spark UDF surface does not
carry, as for the functions the ledger lists with that argument or return. tools/spark-udf-gaps.txt
lists the three; the other size and copy functions it makes public reach the surface.
Witness: over MobilityDB b2dcdf7d84 and MEOS-API 9b337a00fe the step refusing a public function
the Spark surface stops reaching fails on main's ledger with "3 public functions the surface does
not reach and the ledger does not list", naming posechain_mem_size arg:PoseChain *, raster_copy
ret:Raster * and raster_mem_size arg:Raster *.
Measured over the same pair with the jar built from that catalog and that libmeos: the step
reports no function missing from the ledger, which lists 758 functions.
Why: the ledger states every public function the Spark UDF surface does not reach, so a catalog
change that leaves one unmapped is refused instead of passing in silence.