Conversation
sun-jiao
added a commit
to sun-jiao/flut-renamer
that referenced
this pull request
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK could end the drop before the portal transfer token was resolved asyncly. And the source could then invalidate the transfer token, causing
org.freedesktop.portal.FileTransfer.RetrieveFilesto fail with an Invalid transfer error.This change makes the plugin manage the drop lifecycle explicitly. For portal file transfers, it now:
keep the drag context alive while resolving the portal transfer token;
call
org.freedesktop.portal.FileTransfer.RetrieveFilesto retrieve the file paths;convert the resolved paths to file URIs and pass them through the existing Linux drop handling path;
call
gtk_drag_finish()only after the async portal operation has completed;fall back to requesting text/uri-list if the portal transfer cannot be resolved.