feat(music-data): take the deck model's WASM release packages as engines - #28
Merged
Merged
Conversation
--replay-engine and --recommend-engine now take the ournotes-deck WASM release packages of the pinned model, as the downloaded ournotes-<module>-wasm-vVERSION.tar.gz or its directory. The package's build-info.json must describe that module's WASM package, name the pinned commit and list the SHA-256 of the web binding's JS and WASM files; the binding and build-info.json are copied byte for byte, so the published engine is the released one. The deck pin workflow follows ournotes-deck's releases: it moves the pin to the latest release once its replay and recommendation WASM packages are published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moves the deck model to ournotes-deck v0.0.2 (76e96b617842bdcc031cce98e3dfeead27ddbb85), https://github.com/empty-sekai/ournotes-deck/releases/tag/v0.0.2 Music data files made after this change name the new commit in `provenance.deck.commit`; their deck statistics may differ. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
music-data --replay-engineand--recommend-enginetake the ournotes-deck WASM release packages of the pinned model:ournotes-replay-wasm-vVERSION.tar.gzandournotes-recommend-wasm-vVERSION.tar.gz, or their extracted directories. The package'sbuild-info.jsonmust describe that module's WASM package (kind,module), name the pinned commit and list the SHA-256 of the web binding's JS and WASM files. The web binding andbuild-info.jsonare copied byte for byte into the replay bundle (engine/ournotes_replay_wasm.js,engine/ournotes_replay_wasm_bg.wasm,engine/build-info.json, and the same underrecommend/), so a published engine is the released one and its hashes match the release..github/workflows/deck.ymlfollows ournotes-deck's releases instead of itsmain: it moves the pin to the latest release once that release's replay and recommendation WASM packages are published, and names the tag in the pull request.Tests
tests/test_replaydata.pybuilds synthetic release packages and covers directory and.tar.gzinput, a stale commit, a package of the other module, a changed WASM file, a missing file and a file that is not a package.🤖 Generated with Claude Code