fix(music-data): name the mismatch when an engine package is rejected - #23
Merged
Merged
Conversation
A replay or recommendation engine package whose build.json has another format now says so, with the format it has and the one expected, instead of reporting a commit difference. A commit difference names both commits. A missing deck model identity is reported before the package files are read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nichinichisou0609
force-pushed
the
fix/replay-package-errors
branch
from
October 4, 2026 16:21
e05937a to
d98a850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--replay-engineand--recommend-enginecheck a package'sbuild.jsonagainst the pinned deck model. Both a wrongformatand a wrongcommitused to raisebuild.json commit differs from the pinned deck model. Now:recommend engine: build.json format is 'ournotes.replay-engine/1', not ournotes.recommend-engine/1replay engine: build.json commit '<commit>' differs from the pinned deck model <pinned commit>Tests:
tests/test_replaydata.pycovers each message.🤖 Generated with Claude Code