Skip to content

Fix Ctrl shortcuts in step 2/3 viewers (#546) #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanuszBedkowski merged 2 commits into from
Sep 30, 2026
Merged

Fix Ctrl shortcuts in step 2/3 viewers (#546) #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3fd4e
Fix Ctrl shortcuts in raylib step 2/3 viewers (#546)
michalpelka Sep 29, 2026
02779ab
Step 3: Ctrl+D removes sessions, Ctrl+R randomizes session colors
michalpelka Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 26 additions & 34 deletions apps/multi_session_registration/multi_session_registration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ static const std::vector<ShortcutEntry> appShortcuts = { { "Normal keys", "A", "
{ "", "C", "" },
{ "", "Ctrl+C", "" },
{ "", "D", "" },
{ "", "Ctrl+D", "" },
{ "", "Ctrl+D", "Remove session(s)" },
{ "", "E", "" },
{ "", "Ctrl+E", "" },
{ "", "F", "" },
Expand Down Expand Up @@ -89,7 +89,7 @@ static const std::vector<ShortcutEntry> appShortcuts = { { "Normal keys", "A", "
{ "", "Q", "" },
{ "", "Ctrl+Q", "" },
{ "", "R", "" },
{ "", "Ctrl+R", "Remove session(s)" },
{ "", "Ctrl+R", "Random colors per session" },
{ "", "Shift+R", "" },
{ "", "S", "" },
{ "", "Ctrl+S", "Save project" },
Expand Down Expand Up @@ -3616,51 +3616,48 @@ pose_tait_bryan_from_affine_matrix(m_src.inverse() * m_g);
if (IsFileDropped())
loadDroppedFiles();

// No synthetic key/modifier release after handling a shortcut here:
// rlImGui only forwards modifier edges, so a faked Ctrl release is never
// undone while Ctrl stays held, and the next key press falls through to
// the plain-key view shortcuts (e.g. Ctrl+R, R -> camera "Right" preset).
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_A, false))
{
addSession();

// workaround
io.AddKeyEvent(ImGuiKey_A, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}
if ((project_settings.session_file_names.size() > 0) && !loaded_sessions)
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_L, false))
{
loadSessions();

// workaround
io.AddKeyEvent(ImGuiKey_L, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}
// Same enable rule as the "Manual Loop Closure" menu item; closing is always allowed.
if (is_loop_closure_gui || number_visible_sessions == 1 || number_visible_sessions == 2)
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_M, false))
{
is_loop_closure_gui = !is_loop_closure_gui;

// workaround
io.AddKeyEvent(ImGuiKey_M, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_O, false))
{
openProject();

// workaround
io.AddKeyEvent(ImGuiKey_O, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (project_settings.session_file_names.size() > 0)
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_R, false))
{
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_D, false))
remove_gui = true;

// workaround
io.AddKeyEvent(ImGuiKey_R, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_R, false)) // random colors per session
{
for (auto& session : sessions)
{
session.render_color[0] = float(rand() % 255) / 255.0f;
session.render_color[1] = float(rand() % 255) / 255.0f;
session.render_color[2] = float(rand() % 255) / 255.0f;

for (auto& pc : session.point_clouds_container.point_clouds)
{
pc.traj_color[0] = session.render_color[0];
pc.traj_color[1] = session.render_color[1];
pc.traj_color[2] = session.render_color[2];
pc.render_color[0] = session.render_color[0];
pc.render_color[1] = session.render_color[1];
pc.render_color[2] = session.render_color[2];
}
}
}

if (sessions.size() > 0)
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_S, false))
Expand All @@ -3669,11 +3666,6 @@ pose_tait_bryan_from_affine_matrix(m_src.inverse() * m_g);
saveProjectAs();
else
saveProject();

// workaround
io.AddKeyEvent(ImGuiMod_Shift, false);
io.AddKeyEvent(ImGuiKey_S, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (ImGui::BeginMainMenuBar())
Expand All @@ -3693,7 +3685,7 @@ pose_tait_bryan_from_affine_matrix(m_src.inverse() * m_g);

if (ImGui::MenuItem("Add session(s)", "Ctrl+A"))
addSession();
if (ImGui::MenuItem("Remove session(s)", "Ctrl+R", nullptr, project_settings.session_file_names.size() > 0))
if (ImGui::MenuItem("Remove session(s)", "Ctrl+D", nullptr, project_settings.session_file_names.size() > 0))
remove_gui = true;

if (ImGui::MenuItem("Load sessions", "Ctrl+L", nullptr, (project_settings.session_file_names.size() > 0) && !loaded_sessions))
Expand Down
64 changes: 8 additions & 56 deletions apps/multi_view_tls_registration/multi_view_tls_registration_gui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4826,71 +4826,35 @@ void display()

view_kbd_shortcuts();

// No synthetic key/Ctrl release after handling a shortcut here: rlImGui
// only forwards modifier edges, so a faked Ctrl release is never undone
// while Ctrl stays held, and the next key press falls through to the
// plain-key view shortcuts (e.g. Ctrl+R, R -> camera "Right" preset).
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_A, false))
{
is_pca_gui = !is_pca_gui;

// workaround
io.AddKeyEvent(ImGuiKey_A, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_C, false))
{
session.control_points.is_imgui = !session.control_points.is_imgui;

// workaround
io.AddKeyEvent(ImGuiKey_C, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_E, false))
{
is_lio_segments_gui = !is_lio_segments_gui;

// workaround
io.AddKeyEvent(ImGuiKey_E, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_G, false))
{
session.ground_control_points.is_imgui = !session.ground_control_points.is_imgui;

// workaround
io.AddKeyEvent(ImGuiKey_G, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_L, false))
{
is_loop_closure_gui = !is_loop_closure_gui;

// workaround
io.AddKeyEvent(ImGuiKey_L, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_O, false))
{
openSession();

// workaround
io.AddKeyEvent(ImGuiKey_O, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_P, false))
{
is_pose_graph_slam = !is_pose_graph_slam;

// workaround
io.AddKeyEvent(ImGuiKey_P, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_R)) // random colors
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_R, false)) // random colors
{
csPointCloud = CS_RANDOM;

for (auto& pc : session.point_clouds_container.point_clouds)
{
pc.render_color[0] = float(rand() % 255) / 255.0f;
Expand All @@ -4904,10 +4868,6 @@ void display()
pc.traj_color[2] = pc.render_color[2];
}
}

// workaround
io.AddKeyEvent(ImGuiKey_R, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_S, false))
Expand All @@ -4916,13 +4876,9 @@ void display()
saveSubsession();
else
saveSession();

// workaround
io.AddKeyEvent(ImGuiKey_S, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_T)) // solid colors
if (io.KeyCtrl && ImGui::IsKeyPressed(ImGuiKey_T, false)) // solid colors
{
csPointCloud = CS_SOLID;

Expand All @@ -4947,10 +4903,6 @@ void display()
pc.traj_color[2] = pc.render_color[2];
}
}

// workaround
io.AddKeyEvent(ImGuiKey_T, false);
io.AddKeyEvent(ImGuiMod_Ctrl, false);
}

if (ImGui::BeginMainMenuBar())
Expand Down
Loading