fix(tak): unknown for relayed twins without a description; symbol sets by family - #2235
Merged
Merged
Conversation
…s by family Two findings from the first deployment of the table-backed CoT types: - A relayed STANAG twin whose NODE_DESCRIPTION had not arrived yet has no description and no vehicle class, and the no-description rule made it friendly. Only a twin attached to this server (a vehicle class, or a ground-control twin) is friendly without a description; anything else is unknown. - Sources spell symbol sets differently (LAND_INSTALLATION and LAND_INSTALLATIONS both occur); the dimension now comes from the family prefix (AIR*, SPACE*, LAND_*, SEA_SURFACE*, SEA_SUBSURFACE*, MINE_WARFARE*).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2233, from its first deployment on a live COP.
1. Relayed twins without a description were friendly. A relayed STANAG 4817 twin whose
NODE_DESCRIPTIONhas not arrived yet has no description and no vehicle class. The no-description rule (meant for vehicles attached to this server) published it asa-f-X. Now:2. Symbol-set spellings. Sources spell the same set differently;
SymbolSetEnum_LAND_INSTALLATIONS(plural) occurred live and fell through toX. The dimension now comes from the family prefix:AIR*,SPACE*,LAND_*/DISMOUNTED*,SEA_SURFACE*,SEA_SUBSURFACE*/MINE_WARFARE*. The 2525D two-digit codes still work.Tests: new cases for the plural and
AIR_MISSILEspellings, and a relayed twin without a description (unknown). 158 twin/TAK/CoT tests pass locally (Java 21).