fix(server): harden edge cases with regression coverage - #2229
Merged
Merged
Conversation
Refs: MSG-308
…into fix/periodic-runner-test-flake
…into fix/periodic-runner-test-flake
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bring the latest development changes into fix/periodic-runner-test-flake before final unit-test validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch started as test-flake cleanup and was expanded into a focused coverage pass. The majority of the diff is test/support code, with small production fixes only where regression tests demonstrated incorrect behavior.
Test and coverage work
Production fixes proven by tests
Review notes
Against the current development branch, the diff is predominantly tests/support:
The NATS publish-ordering change is the most significant runtime behavior change. It waits for asynchronous destination resolution before storing the message, providing ordering/backpressure rather than dispatching stores from completion callbacks.
Verification
An earlier Jenkins run on this branch completed with 0 failures and increased coverage by approximately 0.5 percentage points.
The current head contains an additional coverage/fix batch after that run, so a fresh Jenkins run is required before merge.
The branch is also currently behind development and should be updated/revalidated before merge.